feat(mcms): log "from", "to" and "raw data" sent on-chain during fork tests #655
Conversation
🦋 Changeset detectedLatest commit: 33660b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
engine/cld/legacy/cli/mcmsv2/testdata/domains/testdomain/cmd/internal/cli/app.go
Fixed
Show fixed
Hide fixed
gustavogama-cll
force-pushed
the
ggama/add-rawdata-to-from-fork-tests
branch
2 times, most recently
from
35f3650 to
ab9185a
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors fork testing infrastructure to improve transaction logging and test coverage. The main changes include extracting fork execution logic into a dedicated function with comprehensive logging, converting environment pointer parameters to value types throughout the codebase, and exposing the container field in CTFAnvilChainProvider for external access in tests.
Key changes:
- Introduced
executeForkfunction with detailed transaction logging (from, to, data fields) - Refactored to pass
Environmentby value instead of pointer - Made
Containerfield public inCTFAnvilChainProviderfor test access
Reviewed changes
Copilot reviewed 24 out of 36 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| engine/cld/legacy/cli/mcmsv2/execute_fork.go | New file implementing fork execution with transaction logging |
| engine/cld/legacy/cli/mcmsv2/execute_fork_test.go | New comprehensive test suite for fork execution |
| engine/cld/legacy/cli/mcmsv2/mcms_v2.go | Refactored to use value types and removed fork execution code |
| engine/cld/legacy/cli/mcmsv2/mcms_v2_test.go | Updated to use value types and new helper signatures |
| chain/evm/provider/ctf_anvil_provider.go | Made Container field public |
| chain/evm/provider/ctf_anvil_provider_test.go | Updated references to use public Container field |
| engine/cld/legacy/cli/mcmsv2/testdata/domains/testdomain/* | Test domain scaffolding files |
| .changeset/public-mugs-agree.md | Changeset entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gustavogama-cll
force-pushed
the
ggama/add-rawdata-to-from-fork-tests
branch
4 times, most recently
from
4ac5e7c to
dd03c7e
Compare
gustavogama-cll
force-pushed
the
ggama/add-rawdata-to-from-fork-tests
branch
from
dd03c7e to
99dd07a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gustavogama-cll
force-pushed
the
ggama/add-rawdata-to-from-fork-tests
branch
from
99dd07a to
33660b5
Compare
gustavogama-cll
changed the title
gustavogama-cll
changed the title
|
gustavogama-cll
changed the title
3 participants
As requested by the payments team, log the "from", "to" and "data" fields sent on-chain during a fork test.
The PR also adds the first, basic integration test for the fork test feature.
OPT-349