fix(jd): remove wsrpc from error message #666
Merged
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer reguire WSRPC as part creating a JD client, removing this from the error message to be clearer.
🦋 Changeset detectedLatest commit: 74338ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates error messaging to reflect that wsRPC is no longer required for JD client creation. The change removes outdated references to wsRPC endpoints from warning messages.
Changes:
- Updated warning messages in two environment loading functions to only mention gRPC endpoint
- Added a changeset documenting this fix
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| engine/cld/environment/fork.go | Removed wsRPC reference from JD initialization warning message |
| engine/cld/environment/environment.go | Removed wsRPC reference from JD initialization warning message |
| .changeset/four-terms-warn.md | Added changeset entry documenting the error message fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
jkongie
approved these changes
Jan 14, 2026
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Patch Changes - [#660](#660) [`a8928d5`](a8928d5) Thanks [@ecPablo](https://github.com/ecPablo)! - fix: avoid loading proposal ctx if the provider is nil chore: add deprecation warning to mcmsv2 commands - [#666](#666) [`d5bcb7c`](d5bcb7c) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - fix(jd): remove wsrpc from error message - [#655](#655) [`3791c84`](3791c84) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - feat: log from, to and raw data in forktests - [#658](#658) [`504cfaa`](504cfaa) Thanks [@ecPablo](https://github.com/ecPablo)! - fix proposal analyzer render issues with array details --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer reguire WSRPC as part creating a JD client, removing this from the error message to be clearer.