-
Notifications
You must be signed in to change notification settings - Fork 2
fix(migration):include datastore type all in configuration check #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(migration):include datastore type all in configuration check #675
Conversation
🦋 Changeset detectedLatest commit: 2d23fed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a migration command to properly handle environments configured with datastore type "all". Previously, the command would incorrectly reject environments configured with DatastoreTypeAll, even though such configurations should include catalog functionality.
Changes:
- Updated the datastore type validation logic to accept both
DatastoreTypeCatalogandDatastoreTypeAllconfigurations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1754e2a to
2d23fed
Compare
|
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.75.1 ### Patch Changes - [#675](#675) [`595b463`](595b463) Thanks [@ajaskolski](https://github.com/ajaskolski)! - fix(migration):include configuration check for datastore type all --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>





No description provided.