Skip to content

refactor: update stale migration terminology to changeset#713

Merged
bytesizedroll merged 3 commits intomainfrom
CLD-1166/more-mig-cleanup
Feb 6, 2026
Merged

refactor: update stale migration terminology to changeset#713
bytesizedroll merged 3 commits intomainfrom
CLD-1166/more-mig-cleanup

Conversation

@bytesizedroll
Copy link
Contributor

Replace legacy "migration" terminology with "changeset" throughout
comments, variable names, and error messages for consistency with
durable pipelines.

Changes include:

  • Rename function params: loadMigration → loadChangesets
  • Rename variables: migDirPath → dirPath, migration → registry
  • Rename test mocks: mockMigrationDS → mockSourceDS
  • Update doc comments and error messages
  • Remove dead commented-out migration test code

Replace legacy "migration" terminology with "changeset" throughout
comments, variable names, and error messages for consistency with
durable pipelines.

Changes include:
- Rename function params: loadMigration → loadChangesets
- Rename variables: migDirPath → dirPath, migration → registry
- Rename test mocks: mockMigrationDS → mockSourceDS
- Update doc comments and error messages
- Remove dead commented-out migration test code
@bytesizedroll bytesizedroll requested a review from a team as a code owner February 5, 2026 18:49
Copilot AI review requested due to automatic review settings February 5, 2026 18:49
@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2026

🦋 Changeset detected

Latest commit: 279641f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
chainlink-deployments-framework Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

👋 bytesizedroll, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the codebase to replace outdated "migration" terminology with "changeset" throughout comments, variable names, function parameters, and error messages. This update aligns the codebase with the current durable pipelines architecture.

Changes:

  • Renamed function parameters and variables (e.g., loadMigrationloadChangesets, migrationregistry)
  • Updated test mock names for clarity (mockMigrationDSmockSourceDS)
  • Revised documentation comments and error messages to reference "changeset" instead of "migration"

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
File Description
engine/cld/scaffold/templates/pipelines.go.tmpl Updated template comments to reference changesets
engine/cld/scaffold/templates/cmd_internal_app.go.tmpl Updated error message to reference changesets
engine/cld/offchain/propose_job.go Updated TODO comments to reference changesets
engine/cld/legacy/cli/mcmsv2/testdata/domains/testdomain/testnet/pipelines.go Updated template comments to reference changesets
engine/cld/legacy/cli/commands/template_input_test.go Renamed test stubs and action functions from migration to changeset terminology
engine/cld/legacy/cli/commands/jd.go Updated TODO comment to reference changesets
engine/cld/legacy/cli/commands/durable-pipelines_test.go Renamed test stubs and updated error messages to reference changesets
engine/cld/legacy/cli/commands/durable-pipelines.go Renamed function parameters, variables, and updated comments/messages to reference changesets
engine/cld/environment/options.go Updated function documentation to reference changesets
engine/cld/domain/paths.go Updated constant comment to reference changesets
engine/cld/domain/jobs.go Updated deprecation comment to reference changesets
engine/cld/domain/fixture_test.go Updated test comments to reference changesets
engine/cld/domain/envdir_test.go Updated test names and comments to reference changesets
engine/cld/domain/domain_test.go Removed commented-out migration test code
engine/cld/domain/domain.go Updated Domain struct documentation to reference changesets
engine/cld/domain/artifacts_test.go Updated test names and comments to reference changesets
engine/cld/domain/artifacts.go Updated struct documentation and renamed local variables to reference changesets
engine/cld/changeset/common.go Updated function documentation to reference changesets
deployment/changeset.go Updated ChangeSetV2 documentation to reference durable pipelines
datastore/catalog_syncer_test.go Renamed mock variables and updated test data to use more generic terminology
datastore/catalog_syncer_integration_test.go Updated test comments and variable names to reference changesets
datastore/catalog_syncer.go Updated function documentation to reference changesets
.changeset/many-parrots-pick.md Added changeset description for this refactoring

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cl-sonarqube-production
Copy link

Copy link
Collaborator

@graham-chainlink graham-chainlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bytesizedroll bytesizedroll added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit 643bbb7 Feb 6, 2026
20 checks passed
@bytesizedroll bytesizedroll deleted the CLD-1166/more-mig-cleanup branch February 6, 2026 01:44
github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## chainlink-deployments-framework@0.80.0

### Minor Changes

-
[#713](#713)
[`643bbb7`](643bbb7)
Thanks [@bytesizedroll](https://github.com/bytesizedroll)! - refactor:
update stale migration terminology to changeset

    Replace legacy "migration" terminology with "changeset" throughout
    comments, variable names, and error messages for consistency with
    durable pipelines.

    Changes include:

    -   Rename function params: loadMigration → loadChangesets
    -   Rename variables: migDirPath → dirPath, migration → registry
    -   Rename test mocks: mockMigrationDS → mockSourceDS
    -   Update doc comments and error messages
    -   Remove dead commented-out migration test code

### Patch Changes

-
[#707](#707)
[`52eb9f5`](52eb9f5)
Thanks [@patricios-space](https://github.com/patricios-space)! - bump
chainlink-ton and mcms to bring latest version that uses new exit code
interface

-
[#705](#705)
[`50640db`](50640db)
Thanks [@bytesizedroll](https://github.com/bytesizedroll)! - remove
migration archive functionality

-
[#709](#709)
[`461acc5`](461acc5)
Thanks [@ajaskolski](https://github.com/ajaskolski)! - refactor: adds
modular cmd for datastore

-
[#715](#715)
[`124dfef`](124dfef)
Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - chore:
add ton to mcms chain access adapter

-
[#712](#712)
[`3584647`](3584647)
Thanks [@ecPablo](https://github.com/ecPablo)! - reduce log level of
skipping chains logs from WARN to INFO

-
[#710](#710)
[`3c33586`](3c33586)
Thanks [@ecPablo](https://github.com/ecPablo)! - fix nil values handling
during upf yaml marshalling

-
[#708](#708)
[`d357cb6`](d357cb6)
Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - fix:
run health check and try multiple RPCs in fork tests

-
[#711](#711)
[`a72317e`](a72317e)
Thanks [@bytesizedroll](https://github.com/bytesizedroll)! - Rename all
"Migration" terminology in domain layer methods to
    "Changeset" for consistency with durable pipelines terminology.

    EnvDir:

    -   MergeMigrationDataStore -> MergeChangesetDataStore
    -   MergeMigrationDataStoreCatalog -> MergeChangesetDataStoreCatalog
    -   MergeMigrationAddressBook -> MergeChangesetAddressBook
    -   RemoveMigrationAddressBook -> RemoveChangesetAddressBook

    ArtifactsDir:

    -   MigrationDirPath -> ChangesetDirPath
    -   CreateMigrationDir -> CreateChangesetDir
    -   RemoveMigrationDir -> RemoveChangesetDir
    -   MigrationDirExists -> ChangesetDirExists
- MigrationOperationsReportsFileExists ->
ChangesetOperationsReportsFileExists
    -   LoadAddressBookByMigrationKey -> LoadAddressBookByChangesetKey
    -   LoadDataStoreByMigrationKey -> LoadDataStoreByChangesetKey

    Internal helpers:

    -   loadDataStoreByMigrationKey -> loadDataStoreByChangesetKey
    -   loadAddressBookByMigrationKey -> loadAddressBookByChangesetKey

    Parameter renames: migKey/migkey -> csKey

    BREAKING CHANGE: All public domain layer methods with "Migration" in
    their name have been renamed to use "Changeset" instead. Update all
    callers to use the new method names.

---------

Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants