refactor(modular-cmds): add address book modular cmds#719
Conversation
🦋 Changeset detectedLatest commit: ab92f4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ajaskolski
force-pushed
the
refactor-addressbook-add-modular-cmd
branch
from
585d998 to
fd880b9
Compare
|
1 similar comment
|
There was a problem hiding this comment.
Pull request overview
Refactors the legacy address-book CLI commands by introducing a new modular engine/cld/commands/addressbook command group and delegating the legacy implementation to it for backward compatibility.
Changes:
- Added a new modular
address-bookcommand group (merge,migrate,remove) with injectable deps and dedicated tests. - Updated legacy
address-bookcommand to delegate to the modular implementation. - Adjusted legacy tests around flag scoping (environment flag no longer on the root).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| engine/cld/legacy/cli/commands/addressbook.go | Replaces legacy implementation with a delegating wrapper to the modular command. |
| engine/cld/legacy/cli/commands/addressbook_test.go | Updates legacy tests to match the modular command’s flag structure. |
| engine/cld/commands/commands.go | Exposes AddressBook() factory for the modular commands entrypoint. |
| engine/cld/commands/addressbook/command.go | Adds modular address-book root command, config validation, and wiring of subcommands. |
| engine/cld/commands/addressbook/deps.go | Introduces injectable dependencies with production defaults for address-book operations. |
| engine/cld/commands/addressbook/merge.go | Adds modular merge subcommand implementation and flag wiring. |
| engine/cld/commands/addressbook/migrate.go | Adds modular migrate subcommand implementation and flag wiring. |
| engine/cld/commands/addressbook/remove.go | Adds modular remove subcommand implementation and flag wiring. |
| engine/cld/commands/addressbook/command_test.go | Adds comprehensive tests for structure, flags, validation, and subcommand behavior. |
| .changeset/few-chefs-guess.md | Adds a patch changeset entry describing the refactor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ajaskolski
force-pushed
the
refactor-addressbook-add-modular-cmd
branch
from
fd880b9 to
da40baf
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.80.1 ### Patch Changes - [#719](#719) [`f4aad62`](f4aad62) Thanks [@ajaskolski](https://github.com/ajaskolski)! - refactor(modular-cmds): create addressbook modular command and delegate legacy one to it - [#730](#730) [`c6b6eae`](c6b6eae) Thanks [@krebernisak](https://github.com/krebernisak)! - Bump github.com/smartcontractkit/chainlink-ton@83535910e2c0 and use bounded trace to confirm tx - [#728](#728) [`3a7f8d0`](3a7f8d0) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - chore: bump CTF to v0.14.0 - [#716](#716) [`8c0cc40`](8c0cc40) Thanks [@bytesizedroll](https://github.com/bytesizedroll)! - Migration reference fix - [#714](#714) [`c4522c1`](c4522c1) Thanks [@FelixFan1992](https://github.com/FelixFan1992)! - add Stellar support for mcms adapters, RPC provider, chain config, and blockchain - [#723](#723) [`9e501d5`](9e501d5) Thanks [@RodrigoAD](https://github.com/RodrigoAD)! - Fix sui timelock decoder - [#725](#725) [`8ce7726`](8ce7726) Thanks [@FelixFan1992](https://github.com/FelixFan1992)! - add a ctf provider for Stellar - [#729](#729) [`901ba0b`](901ba0b) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - chore: bump chain-selectors to v1.0.96 - [#720](#720) [`b296b7d`](b296b7d) Thanks [@krebernisak](https://github.com/krebernisak)! - Revert chainlink-ccip/chains/solana to 85accaf3d28d (availabel contract release) - [#733](#733) [`9fcb21e`](9fcb21e) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - chore: bump mcms to v0.36.0 --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Create modular addresbook command and delegate legacy equivalent to it for backwards compatibility.
Few additional adjustments and refinements:
https://smartcontract-it.atlassian.net/issues?filter=26331&selectedIssue=CLD-1158