Skip to content

docs(mcms): add proposal analysis package usage docs#799

Open
graham-chainlink wants to merge 1 commit intomainfrom
ggoh/OPT-409/add-proposalanalysis-docs
Open

docs(mcms): add proposal analysis package usage docs#799
graham-chainlink wants to merge 1 commit intomainfrom
ggoh/OPT-409/add-proposalanalysis-docs

Conversation

@graham-chainlink
Copy link
Collaborator

What changed

  • Added doc.go to engine/cld/mcms/proposalanalysis with an end-to-end engine usage flow: create engine, register analyzers, register renderer, run analysis, and render with RenderTo.
  • Added analyzer/doc.go describing analyzer extension points and a concrete custom ProposalAnalyzer implementation example.
  • Added renderer/doc.go describing renderer extension points and a concrete custom renderer implementation example.

Why

These docs make the proposal analysis extension model discoverable and consistent, so engineers can implement and wire custom analyzers/renderers without reverse-engineering tests and internals.

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2026

⚠️ No Changeset found

Latest commit: a251f13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graham-chainlink graham-chainlink marked this pull request as ready for review February 27, 2026 02:40
@graham-chainlink graham-chainlink requested a review from a team as a code owner February 27, 2026 02:40
Copilot AI review requested due to automatic review settings February 27, 2026 02:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds package-level GoDoc documentation for the MCMS proposal analysis engine and its extension points (analyzers/renderers) to make the engine workflow and customization model easier to discover.

Changes:

  • Added end-to-end engine usage flow documentation for creating an engine, registering analyzers/renderers, running analysis, and rendering output.
  • Added analyzer extension-point documentation with a concrete ProposalAnalyzer example.
  • Added renderer extension-point documentation with a concrete custom renderer example.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
engine/cld/mcms/proposalanalysis/doc.go Documents the overall engine workflow and a full usage example.
engine/cld/mcms/proposalanalysis/analyzer/doc.go Documents analyzer interfaces/extension points and an example analyzer implementation.
engine/cld/mcms/proposalanalysis/renderer/doc.go Documents renderer interface/extension point and an example renderer implementation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Document how to create and run the proposal analysis engine, and how to implement custom analyzers and renderers so teams can integrate the extension points consistently.
@graham-chainlink graham-chainlink force-pushed the ggoh/OPT-409/add-proposalanalysis-docs branch from 9ac4d55 to a251f13 Compare February 27, 2026 02:46
@cl-sonarqube-production
Copy link

Copy link
Contributor

@ecPablo ecPablo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,74 @@
/*
Package analyzer defines analyzer interfaces used by the proposal analysis engine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to also add a page on the docs/ folder with similar information and examples.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah deciding on this, will see how we go, maybe we will add a more official page on the docs.cld too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants