Fix health report logic in listener #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
previously approved these changes
May 19, 2025
silaslenihan
previously approved these changes
May 19, 2025
amit-momin
previously approved these changes
May 19, 2025
reductionista
previously approved these changes
May 19, 2025
prashantkumar1982
previously approved these changes
May 19, 2025
chains/heads/listener.go
Outdated
| var err error | ||
| if !l.ReceivingHeads() { | ||
| err = errors.New("Listener is not receiving heads") | ||
| err = errors.Join(err, errors.New("Listener is not receiving heads")) |
Collaborator
There was a problem hiding this comment.
The var err is just declared above, and not used.
So it is really unnecessary to use Join here.
Anyways both New or Join work here, so can leave it whatever
| if noHeadsAlarmDuration > 0 { | ||
| noHeadsAlarmT = time.NewTicker(noHeadsAlarmDuration) | ||
| noHeadsAlarmC = noHeadsAlarmT.C | ||
| defer noHeadsAlarmT.Stop() |
jmank88
previously approved these changes
May 20, 2025
DylanTinianov
previously approved these changes
May 20, 2025
poopoothegorilla
dismissed stale reviews from DylanTinianov, jmank88, prashantkumar1982, reductionista, amit-momin, and silaslenihan
via
1c991c8
poopoothegorilla
force-pushed
the
codex/find-and-fix-important-bug
branch
from
59d2c59 to
1c991c8
Compare
reductionista
approved these changes
May 20, 2025
amit-momin
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
HealthReporterror aggregationreceiveHeaders