Small fixes #47
Merged
Small fixes #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanTinianov
approved these changes
May 21, 2025
Farber98
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files, focusing on improving code clarity, fixing typos, enhancing test coverage, and updating documentation. Below is a summary of the most important changes:
Code Improvements and Bug Fixes:
chains/heads/tracker.goby replacing "conical" with "canonical" to improve clarity. ([chains/heads/tracker.goL517-R517](https://github.com/smartcontractkit/chainlink-framework/pull/47/files#diff-81a00f45aa1d075cfca2c3c6390b1dde73f95ba086929e170ef4f702967cd374L517-R517))Test Enhancements:
TestStartSendOnlyNodeinmultinode/send_only_node_test.goto use a sharedmetricsmock object instead of creating new instances in multiple places, ensuring consistency and reducing redundancy. ([[1]](https://github.com/smartcontractkit/chainlink-framework/pull/47/files#diff-44ddef0e62d76e24b41b613d2efecd9429a942f80a934cb17d3e64419613c6e8R80-R86),[[2]](https://github.com/smartcontractkit/chainlink-framework/pull/47/files#diff-44ddef0e62d76e24b41b613d2efecd9429a942f80a934cb17d3e64419613c6e8L108-R112))TestStartSendOnlyNodeto verify the number of calls toIncrementNodeTransitionsToUnreachable,IncrementNodeTransitionsToAlive, andIncrementNodeTransitionsToInvalidChainID, improving test coverage for node state transitions. ([[1]](https://github.com/smartcontractkit/chainlink-framework/pull/47/files#diff-44ddef0e62d76e24b41b613d2efecd9429a942f80a934cb17d3e64419613c6e8R97-R98),[[2]](https://github.com/smartcontractkit/chainlink-framework/pull/47/files#diff-44ddef0e62d76e24b41b613d2efecd9429a942f80a934cb17d3e64419613c6e8R124-R126))Documentation Updates:
README.mdintools/evm-chain-bindingsto fix a file path typo, changinginternal/gen/evm/solity_types_mapping.gotopkg/gen/evm/solidity_types_mapping.go. ([tools/evm-chain-bindings/README.mdL21-R21](https://github.com/smartcontractkit/chainlink-framework/pull/47/files#diff-aeab9096a6620c61526a749e197058ca19f84362499e8ecd4f633be2d6d22cbdL21-R21))