Improve head listener health report formatting #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chains/heads/listener.go
Outdated
| var err error | ||
| if !l.ReceivingHeads() { | ||
| switch { | ||
| case !connected && !receivingHeads: |
Contributor
There was a problem hiding this comment.
can we just use errors.Errorf("Listener connected = %t, receiving heads = %t") instead of this switch?
Contributor
Author
There was a problem hiding this comment.
Would look like this, I don't think it makes a difference
func (l *listener[HTH, S, ID, BLOCK_HASH]) HealthReport() map[string]error {
receivingHeads := l.ReceivingHeads()
connected := l.Connected()
var err error
if !receivingHeads || !connected {
err = fmt.Errorf("Listener connected = %t, receiving heads = %t", connected, receivingHeads)
}
return map[string]error{l.Name(): err}
}
Contributor
There was a problem hiding this comment.
I think it would be easier to parse in the logs + it would be easy to add another status. (hopefully, we don't care about few additional characters in the log output)
dhaidashenko
approved these changes
May 22, 2025
Unheilbar
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires Dependencies
Resolves Dependencies