PLEX-250 - WriteReport EVM initial implementation #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablolagreca
force-pushed
the
PLEX-250
branch
2 times, most recently
from
e30c395 to
7c15436
Compare
Contributor
silaslenihan
left a comment
silaslenihan
left a comment
There was a problem hiding this comment.
Will there be a followup PR for tests for this new functionality?
dhaidashenko
previously approved these changes
Jun 18, 2025
Contributor
Author
Yes, there's a few test cases missing. I'll add them later on. Tracking the action item in PLEX-1524 |
ilija42
previously approved these changes
Jun 18, 2025
dhaidashenko
previously approved these changes
Jun 20, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
pablolagreca
force-pushed
the
PLEX-250
branch
3 times, most recently
from
07d97d1 to
470b01e
Compare
dhaidashenko
previously approved these changes
Jun 26, 2025
dhaidashenko
previously approved these changes
Jun 27, 2025
ilija42
reviewed
Jun 27, 2025
ilija42
reviewed
Jun 27, 2025
ilija42
reviewed
Jun 27, 2025
ilija42
previously approved these changes
Jun 27, 2025
dhaidashenko
previously approved these changes
Jun 27, 2025
ilija42
previously approved these changes
Jun 27, 2025
ilija42
approved these changes
Jun 27, 2025
dhaidashenko
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEX-250
Requires
smartcontractkit/chainlink-common#1264
Supports
smartcontractkit/chainlink-evm#111
smartcontractkit/chainlink#18170