transition to oos from oos for load balanced multinode rpc #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashnevatia
changed the title
|
👋 yashnevatia, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
multinode/node_lifecycle.go
Outdated
| if n.isLoadBalancedRPC { | ||
| n.declareUnreachable() | ||
| // in case all rpcs behind a load balanced rpc are out of sync, we need to declare out of sync to prevent false transition to alive | ||
| n.declareOutOfSync(syncStatusNoNewHead) |
Contributor
There was a problem hiding this comment.
pass syncIssues to keep track of other issues that RPC might need to resolve before transitioning back to alive
multinode/node_fsm.go
Outdated
| return | ||
| } | ||
| switch n.state { | ||
| case nodeStateAlive: |
Contributor
There was a problem hiding this comment.
nit: it should be ok to relax the constraint and allow self-transition even if RPC is not isLoadBalancedRPC. Just to simplify logic.
dhaidashenko
approved these changes
Jul 29, 2025
ilija42
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires Dependencies
Resolves Dependencies