-
Notifications
You must be signed in to change notification settings - Fork 27
bump ctf-build-image for platform option #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 augustbleeds, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
| # for PR builds, ${{ github.sha }} is the temporary merge commit, we want the head commit instead | ||
| SN_SHA: ${{ github.event.pull_request.head.sha || github.sha }} | ||
| TEST_LOG_LEVEL: debug | ||
| CL_ECR: ${{ secrets.QA_AWS_ACCOUNT_NUMBER }}.dkr.ecr.${{ secrets.QA_AWS_REGION }}.amazonaws.com/chainlink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these were just unused





This enables building and testing Chainlink images for both ARM64 and AMD64 architectures. The chainlink stage/prod environments now use arm64 nodes only , but CI tests still depend on AMD64 images so we have to build both. The PR was pointing to some feature branches but now that that the changes have been merged to the main branch of the .github actions repository we can merge these changes in.
I cleaned up the action also to tag the starknet image with the PR commit hash instead of the merged git hash which is confusing since it does not exist and cannot be fetched outside of the initial PR trigger.
After these changes are merged, we'll need to rebase Dimitris's starknet changes and attempt the rollout again.
Here is evidence the build works in staging without a failed ArgoCD rollout: https://github.com/smartcontractkit/infra-k8s/pull/32462
Co-pilot's summary of changes:
Multi-platform Docker builds:
New multi-platform manifest job:
SHA handling improvements:
Build action upgrade:
Job dependencies updated: