Skip to content

Conversation

@faisal-chainlink
Copy link
Collaborator

@faisal-chainlink faisal-chainlink commented Jan 7, 2026

This PR adds a change to allow the generics to be deducted as long as the PointerTag for the state is available.

For example:

"get_token": {
	Name:          "get_token",
	SignerAddress: accountAddress,
	Params: []codec.SuiFunctionParam{
		{
			Type:              "object_id",
			Name:              "state_pointer",
			GenericDependency: testutils.StringPointer("get_token_pool_state_type"),
			PointerTag: &codec.PointerTag{
				Module:        "burn_mint_token_pool",
				PointerName:   "BurnMintTokenPoolStatePointer",
				DerivationKey: "BurnMintTokenPoolState",
				FieldName:     "burn_mint_token_pool_object_id",
			},
			Required:  true,
			IsMutable: testutils.BoolPointer(true),
		},
	},
},

This no longer requires the the offramp or registry to be bound.

@faisal-chainlink faisal-chainlink marked this pull request as ready for review January 7, 2026 21:46
@faisal-chainlink faisal-chainlink requested a review from a team as a code owner January 7, 2026 21:46
@faisal-chainlink faisal-chainlink merged commit 6e7f8b6 into develop Jan 8, 2026
29 of 40 checks passed
@faisal-chainlink faisal-chainlink deleted the enhancement/improve-generics-extract-method branch January 8, 2026 00:15
faisal-chainlink added a commit that referenced this pull request Jan 8, 2026
* use the state object of type to extract generic

* remove unnecessary args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants