Skip to content

Chore: misc refactor#373

Open
faisal-chainlink wants to merge 8 commits intodevelopfrom
chore/misc-refactor
Open

Chore: misc refactor#373
faisal-chainlink wants to merge 8 commits intodevelopfrom
chore/misc-refactor

Conversation

@faisal-chainlink
Copy link
Copy Markdown
Collaborator

No description provided.

@faisal-chainlink faisal-chainlink changed the title Chore/misc refactor Chore: misc refactor Apr 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Hello, @faisal-chainlink! 👋
This Pull Request requires regenerating the contract bindings
Run:

  • nix develop -c task bindings:generate
  • Commit the updates

/// the receiverObjectIds count in a CCIP message matches what the receiver
/// registered, preventing object injection attacks.
expected_receiver_object_id_count: u64,
}
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}
public struct MiscConfigs {
/// The number of extra object IDs that the receiver's ccip_receive callback
/// expects beyond the standard 3 parameters (expected_message_id,
/// &CCIPObjectRef, Any2SuiMessage). The relayer uses this to validate that
/// the receiverObjectIds count in a CCIP message matches what the receiver
/// registered, preventing object injection attacks.
expected_receiver_object_id_count: u64,
}

@faisal-chainlink faisal-chainlink marked this pull request as ready for review April 8, 2026 18:08
@faisal-chainlink faisal-chainlink requested a review from a team as a code owner April 8, 2026 18:08
@faisal-chainlink
Copy link
Copy Markdown
Collaborator Author

Working on edits to remove on-chain changes in this PR

…a (Report #71024)

- Revert on-chain receiver_registry changes to keep fix entirely off-chain
- Convert decodeParam panics to errors with checked type assertions
- Add explicit TypeParameter rejection in ABI parameter decoding
- Add defer/recover defense-in-depth in BuildOffRampExecutePTB
- Fix unchecked assertions in token pool and receiver PTB construction
- Add comprehensive unit tests for malformed and adversarial ABI shapes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant