Feature: cache state object ids + misc refactor #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixFan1992
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some refactoring and misc enhancements to CR:
PackageResolverconstruct to abstract binding and unbinding which will later also be used to cache latest package IDs (with a reasonable timeout).PTBClientto allow for quick access to state ref object IDs (e.g. offramp state object ID) without refetching it from the RPC. This is safe because those IDs do not change with upgrades.GetValuesFromPackageOwnedObjectFieldso it can be re-used between CR and offramp execution flow.GetAddressMappingsmethod in offramp execution flow. Also use the client cache to reduce RPC calls.