Skip to content

Commit a099b2e

Browse files
committed
change return
1 parent b5dbe8b commit a099b2e

File tree

5 files changed

+15
-14
lines changed

5 files changed

+15
-14
lines changed

framework/cmd/interactive.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func createComponentsFromForm(form *nodeSetForm) error {
3030
_ *simple_node_set.Output
3131
err error
3232
)
33-
if err := framework.DefaultNetwork(t, &sync.Once{}); err != nil {
33+
if _, err := framework.DefaultNetwork(&sync.Once{}); err != nil {
3434
return err
3535
}
3636
switch form.Network {

framework/components/clnode/clnode_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ func TestComponentDockerNodeWithSharedDB(t *testing.T) {
4949
}
5050

5151
for _, tc := range testCases {
52-
err := framework.DefaultNetwork(t, &sync.Once{})
52+
_, err := framework.DefaultNetwork(&sync.Once{})
5353
require.NoError(t, err)
5454

5555
t.Run(tc.name, func(t *testing.T) {
@@ -84,7 +84,7 @@ func TestComponentDockerNodeWithDB(t *testing.T) {
8484
}
8585

8686
for _, tc := range testCases {
87-
err := framework.DefaultNetwork(t, &sync.Once{})
87+
_, err := framework.DefaultNetwork(&sync.Once{})
8888
require.NoError(t, err)
8989

9090
t.Run(tc.name, func(t *testing.T) {

framework/components/jd/jd_test.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,21 @@
11
package jd_test
22

33
import (
4-
"github.com/smartcontractkit/chainlink-testing-framework/framework"
5-
"github.com/smartcontractkit/chainlink-testing-framework/framework/components/jd"
6-
"github.com/stretchr/testify/require"
74
"os"
85
"sync"
96
"testing"
7+
8+
"github.com/smartcontractkit/chainlink-testing-framework/framework"
9+
"github.com/smartcontractkit/chainlink-testing-framework/framework/components/jd"
10+
"github.com/stretchr/testify/require"
1011
)
1112

1213
// here we only test that we can boot up JD
1314
// client examples are under "examples" dir
1415
// since JD is private this env var should be set locally and in CI
1516
// TODO: add ComponentDocker prefix to turn this on when we'll have access to ECRs
1617
func TestJD(t *testing.T) {
17-
err := framework.DefaultNetwork(t, &sync.Once{})
18+
_, err := framework.DefaultNetwork(&sync.Once{})
1819
require.NoError(t, err)
1920
_, err = jd.NewJD(&jd.Input{
2021
Image: os.Getenv("CTF_JD_IMAGE"),

framework/components/simple_node_set/nodeset_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
package simple_node_set_test
22

33
import (
4+
"sync"
5+
"testing"
6+
47
"github.com/smartcontractkit/chainlink-testing-framework/framework"
58
"github.com/smartcontractkit/chainlink-testing-framework/framework/components/blockchain"
69
"github.com/smartcontractkit/chainlink-testing-framework/framework/components/clnode"
710
"github.com/smartcontractkit/chainlink-testing-framework/framework/components/postgres"
811
ns "github.com/smartcontractkit/chainlink-testing-framework/framework/components/simple_node_set"
912
"github.com/stretchr/testify/require"
10-
"sync"
11-
"testing"
1213
)
1314

1415
type testCase struct {
@@ -113,7 +114,7 @@ level = 'info'
113114
}
114115

115116
for _, tc := range testCases {
116-
err := framework.DefaultNetwork(t, &sync.Once{})
117+
_, err := framework.DefaultNetwork(&sync.Once{})
117118
require.NoError(t, err)
118119

119120
t.Run(tc.name, func(t *testing.T) {

framework/config.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,23 +143,22 @@ func Load[X any](t *testing.T) (*X, error) {
143143
// return nil, fmt.Errorf("failed to connect AWSSecretsManager: %w", err)
144144
// }
145145
//}
146-
err = DefaultNetwork(t, once)
146+
_, err = DefaultNetwork(once)
147147
require.NoError(t, err)
148148
return input, nil
149149
}
150150

151-
func DefaultNetwork(t *testing.T, once *sync.Once) error {
151+
func DefaultNetwork(once *sync.Once) (*testcontainers.DockerNetwork, error) {
152152
var net *testcontainers.DockerNetwork
153153
var err error
154154
once.Do(func() {
155155
net, err = network.New(
156156
context.Background(),
157157
network.WithLabels(map[string]string{"framework": "ctf"}),
158158
)
159-
testcontainers.CleanupNetwork(t, net)
160159
DefaultNetworkName = net.Name
161160
})
162-
return err
161+
return net, err
163162
}
164163

165164
func RenderTemplate(tmpl string, data interface{}) (string, error) {

0 commit comments

Comments
 (0)