Skip to content

Conversation

@lukaszcl
Copy link
Contributor

@lukaszcl lukaszcl commented Mar 6, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes enhance the functionality of the flakeguard tool by removing redundant Splunk integration directly in the aggregation command, which simplifies the codebase. Moreover, it introduces modular commands for interacting with GitHub and Splunk, allowing more flexible and focused operations. Importantly, it maps test results to specific paths and code owners, providing more detailed and actionable insights for test failures.

What

  • Removed Splunk integration options (splunk-url, splunk-token, splunk-event) from the AggregateResultsCmd flags.
  • Added WithRepoPath and WithCodeOwnersPath options to include repository path and CODEOWNERS file path in the aggregation process.
  • Removed mapping test results to paths and code owners directly in the aggregation command, streamlining its functionality.
  • Added a new command GetGHArtifactLinkCmd for fetching GitHub artifact links, encapsulating this functionality and making it reusable.
  • Introduced a SendToSplunkCmd command for sending test reports to Splunk, isolating this functionality into its own operation.
  • Updated generate-report command to use a failedLogsURL for linking to failed test logs instead of fetching artifact links directly, simplifying its process.
  • Updated test report data in example_test_package to reflect new mappings to test paths and code owners, providing more detailed information on test failures.

@cl-sonarqube-production
Copy link

@lukaszcl lukaszcl merged commit f373285 into main Mar 7, 2025
57 of 62 checks passed
@lukaszcl lukaszcl deleted the DX-90-Include-codeowners-test_path-and-failed_test_log_url-in-Splunk branch March 7, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants