Skip to content

Conversation

@kalverra
Copy link
Contributor

@kalverra kalverra commented Mar 28, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes improve error handling and logging within the parseTestResults function. Specifically, they enhance the way panics and races are attributed to tests, introduce clearer error messages for various failure scenarios, and add error types for specific error conditions. These changes aim to make debugging and understanding test failures easier.

What

  • runner/runner.go:
    • Enhanced error logging and handling in attributePanicToTest function to provide more specific error messages and introduced error types for different failure scenarios.
    • Changed log level from Warn to Error and added printing of error message when unable to attribute panic to a test.
    • Introduced several new error types (ErrFailedToAttributePanicToTest, ErrFailedToParseTimeoutDuration, ErrFailedToExtractTimeoutDuration, ErrDetectedLogAfterCompleteFailedAttribution, ErrDetectedTimeoutFailedParse, ErrDetectedTimeoutFailedAttribution) to clearly identify specific error conditions.
  • runner/runner_test.go:
    • Adjusted tests to include cases for new error handling and checking specific error types (ErrFailedToAttributePanicToTest, ErrFailedToParseTimeoutDuration, ErrFailedToExtractTimeoutDuration, ErrDetectedLogAfterCompleteFailedAttribution, ErrDetectedTimeoutFailedParse, ErrDetectedTimeoutFailedAttribution).

@kalverra kalverra merged commit 7db1c58 into main Apr 4, 2025
57 checks passed
@kalverra kalverra deleted the flakeGuardTimeoutPanics branch April 4, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants