Flakeguard: Accounts for more panic scenarios #1741
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes improve error handling and logging within the
parseTestResultsfunction. Specifically, they enhance the way panics and races are attributed to tests, introduce clearer error messages for various failure scenarios, and add error types for specific error conditions. These changes aim to make debugging and understanding test failures easier.What
runner/runner.go:attributePanicToTestfunction to provide more specific error messages and introduced error types for different failure scenarios.WarntoErrorand added printing of error message when unable to attribute panic to a test.ErrFailedToAttributePanicToTest,ErrFailedToParseTimeoutDuration,ErrFailedToExtractTimeoutDuration,ErrDetectedLogAfterCompleteFailedAttribution,ErrDetectedTimeoutFailedParse,ErrDetectedTimeoutFailedAttribution) to clearly identify specific error conditions.runner/runner_test.go:ErrFailedToAttributePanicToTest,ErrFailedToParseTimeoutDuration,ErrFailedToExtractTimeoutDuration,ErrDetectedLogAfterCompleteFailedAttribution,ErrDetectedTimeoutFailedParse,ErrDetectedTimeoutFailedAttribution).