Skip to content

Refactor URL fields in components to work with kubernetes#1755

Merged
skudasov merged 2 commits intomainfrom
clo-1127/refactor-ctf-outputs
Apr 2, 2025
Merged

Refactor URL fields in components to work with kubernetes#1755
skudasov merged 2 commits intomainfrom
clo-1127/refactor-ctf-outputs

Conversation

@scheibinger
Copy link
Contributor

@scheibinger scheibinger commented Apr 2, 2025

Updated URL fields in components so they are not Docker specific and can work for both Docker and Kubernetes.

  • URLs prefixed with Internal, can be used as Docker internal URLs or Kubernetes internal URLs. In kubernetes the scope of internal can vary, can be either local URL available within the same namespace or cluster local URL, depending on the needs
  • URLs prefixed with External are for integrating components externally
HostURL -> ExternalURL
HostHTTPUrl -> ExternalHTTPUrl
HostWSUrl  -> ExternalWSUrl
HostWSRPCUrl -> ExternalWSRPCUrl
HostGRPCUrl -> ExternalGRPCUrl
DockerURL -> InternalURL
DockerP2PUrl -> InternalP2PUrl
DockerGRPCUrl -> InternalGRPCUrl
DockerWSRPCUrl -> InternalWSRPCUrl
DockerInternalURL -> InternalURL
DockerInternalHTTPUrl -> InternalHTTPUrl
DockerInternalWSUrl  -> InternalWSUrl
JDDockerInternalURL -> JDInternalURL

@scheibinger scheibinger requested a review from a team as a code owner April 2, 2025 13:12
@skudasov skudasov merged commit 56566ca into main Apr 2, 2025
59 of 60 checks passed
@skudasov skudasov deleted the clo-1127/refactor-ctf-outputs branch April 2, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants