Skip to content

Conversation

@skudasov
Copy link
Contributor

@skudasov skudasov commented Apr 22, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes standardize the use of constants for blockchain types and families across different blockchain component implementations, enhancing code readability and maintainability. It also introduces a new "Type" field in the blockchain output struct to clearly distinguish between different blockchain networks.

What

  • framework/components/blockchain/aptos.go
    • Added Type: in.Type to return Output struct to specify the blockchain type.
    • Changed Family: "aptos" to Family: FamilyAptos to use the constant for blockchain family.
  • framework/components/blockchain/blockchain.go
    • Introduced constants for blockchain node Type (e.g., TypeAnvil, TypeGeth) and Family (e.g., FamilyEVM, FamilySolana), replacing hardcoded strings.
    • Added Type string field to Output struct.
  • framework/components/blockchain/containers.go
    • Added Type: in.Type to Output struct in createGenericEvmContainer function to specify the blockchain type.
    • Changed Family: "evm" to Family: FamilyEVM to use the constant for blockchain family.
  • framework/components/blockchain/solana.go
    • Added Type: in.Type to return Output struct to specify the blockchain type.
    • Changed Family: "solana" to Family: FamilySolana to use the constant for blockchain family.
  • framework/components/blockchain/sui.go
    • Added Type: in.Type to return Output struct to specify the blockchain type.
    • Changed Family: "sui" to Family: FamilySui to use the constant for blockchain family.
  • framework/components/blockchain/tron.go
    • Added Type: in.Type to return Output struct to specify the blockchain type.
    • Changed Family: "tron" to Family: FamilyTron to use the constant for blockchain family.

@skudasov skudasov requested a review from a team as a code owner April 22, 2025 13:15
@skudasov skudasov force-pushed the more-metadata-for-blockchains branch from 8f4c479 to d423df3 Compare April 22, 2025 13:43
@skudasov skudasov merged commit 89e6d79 into main Apr 22, 2025
58 checks passed
@skudasov skudasov deleted the more-metadata-for-blockchains branch April 22, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants