Skip to content

Conversation

@mchain0
Copy link
Contributor

@mchain0 mchain0 commented Jun 12, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes introduce a public bucket policy to the Minio S3 provider, enhancing accessibility for public reads. Additionally, they improve testing by verifying file uploads and public access through HTTP requests.

What

  • framework/.changeset/v0.9.4.md
    • Added a changeset file for version 0.9.4, mentioning the test for a local S3 provider with a public bucket policy.
  • framework/components/s3provider/minio.go
    • Added a public bucket policy to the Minio S3 provider setup, allowing s3:GetObject action for all AWS users.
  • framework/components/s3provider/minio_test.go
    • Expanded the TestNew and TestNewFrom test cases to include checks for the new public bucket policy by testing file uploads and verifying public access through an HTTP get request.
    • Introduced helperUploadFile and helperDownloadFile functions to assist with uploading to and downloading from the Minio server, facilitating the testing of the public access feature.

@mchain0 mchain0 marked this pull request as ready for review June 12, 2025 08:18
@mchain0 mchain0 requested a review from a team as a code owner June 12, 2025 08:18
@mchain0 mchain0 merged commit d6febbd into main Jun 12, 2025
63 checks passed
@mchain0 mchain0 deleted the cappl-847-wf-storage-test-policy branch June 12, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants