Skip to content

Chore: Extend input with platform image#1912

Merged
skudasov merged 3 commits intomainfrom
chore/extend-input-with-platform-image
Jun 20, 2025
Merged

Chore: Extend input with platform image#1912
skudasov merged 3 commits intomainfrom
chore/extend-input-with-platform-image

Conversation

@faisal-chainlink
Copy link
Contributor

@faisal-chainlink faisal-chainlink commented Jun 20, 2025

Allows specifying the ImagePlatform field in Input which is useful for cases like sui to when doing local testing.

In local we use the arm64/v8 platform instead of amd64 for Sui. This might not be available in other chains so it's currently set to an optional config and used only for Sui node spec.


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes introduce an optional ImagePlatform parameter to the blockchain component configuration, allowing configuration of the image platform for blockchain nodes, and modify the Sui blockchain component to utilize this new parameter if provided, defaulting to "linux/amd64" if not specified. This flexibility can be crucial for environments that require specific image architectures.

What

  • framework/components/blockchain/blockchain.go:
    • Added a new optional field ImagePlatform *string to the Input struct. This allows specifying the platform of the Docker image to use for the blockchain node, providing flexibility for cross-platform deployments.
  • framework/components/blockchain/sui.go:
    • Modified the newSui function to use the ImagePlatform from the input configuration if available. Defaults to "linux/amd64" if ImagePlatform is not specified. This ensures that the specified or default architecture is used when pulling and running the Docker image for the Sui node.

@faisal-chainlink faisal-chainlink requested a review from a team as a code owner June 20, 2025 11:10
@skudasov skudasov merged commit 5714c5e into main Jun 20, 2025
75 of 77 checks passed
@skudasov skudasov deleted the chore/extend-input-with-platform-image branch June 20, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants