Chore: Extend input with platform image#1912
Merged
Conversation
skudasov
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows specifying the
ImagePlatformfield inInputwhich is useful for cases likesuito when doing local testing.In local we use the
arm64/v8platform instead ofamd64for Sui. This might not be available in other chains so it's currently set to an optional config and used only for Sui node spec.Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes introduce an optional
ImagePlatformparameter to the blockchain component configuration, allowing configuration of the image platform for blockchain nodes, and modify the Sui blockchain component to utilize this new parameter if provided, defaulting to "linux/amd64" if not specified. This flexibility can be crucial for environments that require specific image architectures.What
ImagePlatform *stringto theInputstruct. This allows specifying the platform of the Docker image to use for the blockchain node, providing flexibility for cross-platform deployments.newSuifunction to use theImagePlatformfrom the input configuration if available. Defaults to "linux/amd64" ifImagePlatformis not specified. This ensures that the specified or default architecture is used when pulling and running the Docker image for the Sui node.