[DX-1118] local beholder support #1938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chainlink-testing-framework into dx-1118-local-beholder
…f extra dependencies
skudasov
reviewed
Jun 27, 2025
| // so let's try to connect to a Docker network a couple of times, there must be a race condition in Docker | ||
| // and even when network sandbox has been created and container is running, this call can still fail | ||
| // retrying is simpler than trying to figure out how to correctly wait for the network sandbox to be ready | ||
| var connectNetwork = func(networkName string) error { |
Contributor
There was a problem hiding this comment.
Can't we just be on the same network? Seems like we either need to remove the default network from CTF or to configure this compose to use the same CTF network
Contributor
Author
There was a problem hiding this comment.
and what's the problem with this approach?
skudasov
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chip ingress + red panda
All in separate go module to limit blast radius of all dependencies required by docker-compose wrapped in
testcontainers-go