Skip to content

[CLD-510]: feat: configurable faucet port for Sui#2048

Merged
graham-chainlink merged 1 commit intomainfrom
ggoh/cld-510/sui-port-faucet
Aug 20, 2025
Merged

[CLD-510]: feat: configurable faucet port for Sui#2048
graham-chainlink merged 1 commit intomainfrom
ggoh/cld-510/sui-port-faucet

Conversation

@graham-chainlink
Copy link
Contributor

@graham-chainlink graham-chainlink commented Aug 18, 2025

The inability for us to provide a different port for the SUI faucet port when running the SUI container means that there is a chance that the port is already being used by other process.

JIRA: https://smartcontract-it.atlassian.net/browse/CLD-510


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes introduce a configurable faucet port for the Sui blockchain component, enhancing flexibility in network configurations. This allows users to specify a custom faucet port, accommodating scenarios where the default port may conflict with other services or protocols.

What

  • framework/.changeset/v0.10.15.md
    • Added a changeset file indicating the addition of configurable faucet port for Sui blockchain component.
  • framework/components/blockchain/blockchain.go
    • Added FaucetPort field to the Input struct to allow specifying a custom faucet port for Sui blockchain configurations.
  • framework/components/blockchain/sui.go
    • Modified defaultSui function to set FaucetPort to a default value if it is not specified.
    • Updated newSui function to use the FaucetPort from Input struct for port bindings and account funding, enhancing flexibility for Sui network deployments.

The inability for us to provide a different port for the SUI faucet port when running the SUI container means that there is a chance that the port is already being used by other process.

JIRA: https://smartcontract-it.atlassian.net/browse/CLD-510
@graham-chainlink graham-chainlink marked this pull request as ready for review August 18, 2025 15:17
@graham-chainlink graham-chainlink requested a review from a team as a code owner August 18, 2025 15:17
@graham-chainlink graham-chainlink enabled auto-merge (squash) August 19, 2025 12:43
@graham-chainlink graham-chainlink merged commit ec7ffa0 into main Aug 20, 2025
68 checks passed
@graham-chainlink graham-chainlink deleted the ggoh/cld-510/sui-port-faucet branch August 20, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants