Merged
Conversation
…ork for …" This reverts commit 2284539.
13161a6 to
d32102b
Compare
skudasov
previously approved these changes
Aug 28, 2025
skudasov
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes enhance the reliability and functionality of Docker Compose tests and schema registration in a microservices-based framework. Specifically, the addition of retries in schema registration aims to address transient network issues, while the update in Docker Compose tests ensures a more robust and comprehensive testing environment, including changes to environment variable configuration and service checks.
What
.github/workflows/framework-dockercompose-tests.ymlframework/components/dockercompose/chip_ingress_set/chip_ingress.goframework/components/dockercompose/chip_ingress_set/protos.goframework/components/dockercompose/go.modandgo.sumgithub.com/avast/retry-go/v4as a dependency, enabling the use of retry logic in schema registration.framework/examples/myproject/smoke_chip_ingress_test.go