Merged
Conversation
|
👋 Tofel, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new chiprouter component intended to “own” the fixed ChIP ingress port and fan out incoming telemetry to multiple downstream subscribers, simplifying local CRE topologies.
Changes:
- Add a new
framework/components/chiprouterGo module, container image (Dockerfile), runtime binary (cmd/chip-router), and a CTF Testcontainers component wrapper. - Update documentation to include the new Chip Router component and add a changeset entry.
- Remove the default value for the compatibility testing CLI
buildcmdflag and updatedockercomposemodule dependencies.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| framework/components/dockercompose/go.mod | Dependency bumps (protobuf/otel/x/*/grpc/etc.). |
| framework/components/dockercompose/go.sum | Corresponding checksum updates for dependency bumps. |
| framework/components/chiprouter/go.mod | New module definition for chiprouter component. |
| framework/components/chiprouter/go.sum | New dependency lockfile for chiprouter module. |
| framework/components/chiprouter/Dockerfile | Container build/runtime image for chip-router binary. |
| framework/components/chiprouter/cmd/chip-router/main.go | Implements router runtime: gRPC ingress + HTTP admin API for subscriber registration. |
| framework/components/chiprouter/chiprouter.go | CTF component wrapper to run chip-router via Testcontainers + admin API helpers. |
| framework/cmd/main.go | Removes default value for buildcmd flag. |
| framework/.changeset/v0.15.11.md | Release note entry for buildcmd change + chiprouter addition. |
| book/src/SUMMARY.md | Adds Chip Router doc to the book table of contents. |
| book/src/framework/components/chiprouter/chip_router.md | New Chip Router documentation page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8 tasks
Tofel
force-pushed
the
dx-3050-chip-fanout-router
branch
from
2482d63 to
f9a4559
Compare
Tofel
force-pushed
the
dx-3050-chip-fanout-router
branch
from
37a9c66 to
b6fb26c
Compare
Tofel
force-pushed
the
dx-3050-chip-fanout-router
branch
from
b6fb26c to
10062ac
Compare
Tofel
force-pushed
the
dx-3050-chip-fanout-router
branch
from
047c6a5 to
3e68714
Compare
Tofel
force-pushed
the
dx-3050-chip-fanout-router
branch
from
d5fff4b to
c6d97b7
Compare
skudasov
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the added doc below for description.