-
Notifications
You must be signed in to change notification settings - Fork 4
Fix timelock Go bindings #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 krebernisak, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes timelock Go bindings by replacing SnakeRef[WrappedAddress] with SnakeData[*address.Address], eliminating the need for the intermediate WrappedAddress wrapper type. The change simplifies the codebase by removing unnecessary wrapper code and type conversions.
Key changes:
- Updated timelock type definitions to use
SnakeData[*address.Address]instead ofSnakeRef[WrappedAddress] - Removed the now-unused
WrapAddresseshelper function - Simplified address collection initialization by removing wrapper conversions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/ccip/bindings/common/common.go | Removed WrapAddresses helper function and added TODO comment questioning the need for WrappedAddress type |
| pkg/bindings/mcms/timelock/types.go | Changed proposers, executors, cancellers, and bypassers fields from SnakeRef[WrappedAddress] to SnakeData[*address.Address] |
| deployment/mcms/sequence/deploy_mcms.go | Removed WrapAddresses calls and wrapper type conversions when initializing timelock configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
28061e6 to
d55cc1d
Compare
d55cc1d to
5c8995c
Compare
huangzhen1997
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
common.SnakeRef[common.WrappedAddress]ascommon.SnakeData[common.AddressWrap]common.SnakeData[*address.Address]- doesn't work