Skip to content

Conversation

@krebernisak
Copy link
Collaborator

@krebernisak krebernisak commented Dec 16, 2025

  • Fixes common.SnakeRef[common.WrappedAddress] as common.SnakeData[common.AddressWrap]
  • Remove common.SnakeData[*address.Address] - doesn't work
  • Supports Add TON support mcms#486

Copilot AI review requested due to automatic review settings December 16, 2025 12:39
@krebernisak krebernisak requested a review from a team as a code owner December 16, 2025 12:39
@github-actions
Copy link

👋 krebernisak, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes timelock Go bindings by replacing SnakeRef[WrappedAddress] with SnakeData[*address.Address], eliminating the need for the intermediate WrappedAddress wrapper type. The change simplifies the codebase by removing unnecessary wrapper code and type conversions.

Key changes:

  • Updated timelock type definitions to use SnakeData[*address.Address] instead of SnakeRef[WrappedAddress]
  • Removed the now-unused WrapAddresses helper function
  • Simplified address collection initialization by removing wrapper conversions

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pkg/ccip/bindings/common/common.go Removed WrapAddresses helper function and added TODO comment questioning the need for WrappedAddress type
pkg/bindings/mcms/timelock/types.go Changed proposers, executors, cancellers, and bypassers fields from SnakeRef[WrappedAddress] to SnakeData[*address.Address]
deployment/mcms/sequence/deploy_mcms.go Removed WrapAddresses calls and wrapper type conversions when initializing timelock configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@krebernisak krebernisak force-pushed the chore/mcms-bindings-fix branch from 28061e6 to d55cc1d Compare December 16, 2025 15:44
@krebernisak krebernisak force-pushed the chore/mcms-bindings-fix branch from d55cc1d to 5c8995c Compare December 16, 2025 15:53
@krebernisak krebernisak enabled auto-merge (squash) December 16, 2025 15:59
Copy link
Contributor

@huangzhen1997 huangzhen1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krebernisak krebernisak merged commit 5c01294 into main Dec 16, 2025
35 checks passed
@krebernisak krebernisak deleted the chore/mcms-bindings-fix branch December 16, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants