-
Notifications
You must be signed in to change notification settings - Fork 5
Add BoundCondition fn to support bounded trace #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krebernisak
wants to merge
3
commits into
main
Choose a base branch
from
feat/bounded-trace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| package bindings | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/smartcontractkit/chainlink-ton/pkg/ccip/bindings/offramp" | ||
| "github.com/smartcontractkit/chainlink-ton/pkg/ccip/bindings/router" | ||
| "github.com/smartcontractkit/chainlink-ton/pkg/ton/tracetracking" | ||
| "github.com/smartcontractkit/chainlink-ton/pkg/ton/tvm" | ||
| ) | ||
|
|
||
| // DefaultTraceStopCondition is the default policy for bounded trace tracking - stopping message (DAG) | ||
| // trace tracking in the context of MCMS/CCIP. | ||
| // | ||
| // Notice: we expect account contracts (e.g., Wallet contracts, MCMS/Timelock, multisigs, etc) to accept | ||
| // all incoming messages (replies) and not reject with 0xffff (wrong opcode) but accept/ignore. | ||
| // | ||
| // - we don't track fwd notifications to uninitialized accounts, bounce = false | ||
| // - we don't track outgoing msgs/notifications from third-party CCIP receiver contracts (except for router.CCIPReceiveConfirm) | ||
| var DefaultTraceStopCondition tracetracking.StopCondition = func(parent, current *tracetracking.ReceivedMessage) (bool, error) { | ||
| ec, err := current.ExitCode() | ||
| if err != nil { | ||
| return false, fmt.Errorf("failed to get exit code: %w", err) | ||
| } | ||
|
|
||
| // Stop tracing on NoState exit code (fwd notifications to uninitialized accounts, bounce = false) | ||
| if !current.InternalMsg.Bounce && ec == tvm.ExitCodeComputeSkipReasonNoState { | ||
| return true, nil // stop tracing | ||
| } | ||
|
|
||
| opcodeParent, err := tvm.ExtractOpcode(parent.InternalMsg.Body) | ||
| if err != nil { | ||
| return false, fmt.Errorf("failed to extract opcode from parent message: %w", err) | ||
| } | ||
|
|
||
| opcodeCurrent, err := tvm.ExtractOpcode(current.InternalMsg.Body) | ||
| if err != nil { | ||
| return false, fmt.Errorf("failed to extract opcode from current message: %w", err) | ||
| } | ||
|
|
||
| switch uint64(opcodeParent) { | ||
| case offramp.OpcodeCCIPReceive: | ||
| // Stop tracing if the current message is not router.CCIPReceiveConfirm (i.e. don't consider | ||
| // any other outgoing msgs/notifications from third-party CCIP receiver contracts - on offramp.CCIPReceive) | ||
| return uint64(opcodeCurrent) != router.OpcodeCCIPReceiveConfirm, nil | ||
| } | ||
|
|
||
| return false, nil // Don't stop by default (continue tracing) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.