Skip to content

Conversation

@jadepark-dev
Copy link
Collaborator

@jadepark-dev jadepark-dev commented Jul 15, 2025

Note:

  • Bump CTF to use TVM 11 in mylocalton-docker
    • Enabled skipped counter test
  • Reduced NEXT_BLOCK_GENERATION_DELAY from 2(default) to 0.5
    • 664.72s > 490.88s
--- PASS: TestIntegration (664.72s)
    --- PASS: TestIntegration/TestDepositFees (5.45s)
    --- PASS: TestIntegration/TestCounter (13.29s)
    --- PASS: TestIntegration/TestRequestReply (45.99s)
    --- PASS: TestIntegration/TestRequestReplyWithTwoDependencies (92.70s)
    --- PASS: TestIntegration/TestMemoryContract (14.86s)
    --- PASS: TestIntegration/TestTwoMsgChain (36.88s)
    --- PASS: TestIntegration/AutoAck (66.03s)
    --- PASS: TestIntegration/AcksBeforeCommit (105.66s)
    --- PASS: TestIntegration/AcksAfterCommit (93.42s)
    --- PASS: TestIntegration/OneAckAfterCommit (103.02s)
PASS
--- PASS: TestIntegration (490.88s)
    --- PASS: TestIntegration/TestDepositFees (5.24s)
    --- PASS: TestIntegration/TestCounter (13.30s)
    --- PASS: TestIntegration/TestRequestReply (43.25s)
    --- PASS: TestIntegration/TestRequestReplyWithTwoDependencies (69.53s)
    --- PASS: TestIntegration/TestMemoryContract (14.94s)
    --- PASS: TestIntegration/TestTwoMsgChain (15.25s)
    --- PASS: TestIntegration/AutoAck (37.78s)
    --- PASS: TestIntegration/AcksBeforeCommit (72.37s)
    --- PASS: TestIntegration/AcksAfterCommit (56.86s)
    --- PASS: TestIntegration/OneAckAfterCommit (77.76s)
PASS
  • t.Parallel() causes transactions not being confirmed(not applied)

@jadepark-dev jadepark-dev marked this pull request as ready for review July 15, 2025 10:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates MyLocalTon support to TVM 11, cleans up tracing tests, and optimizes test execution.

  • Add CustomEnv settings for TVM version and block delay in CreateAPIClient
  • Refactor SetUpTest to bulk-create and fund wallets, removing legacy seed-based helpers
  • Replace fmt.Printf with t.Logf across integration tests and increase test parallelism

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
integration-tests/utils/chain.go Configure TVM-11 and block delay via CustomEnv, rename cleanup var
integration-tests/tracetracking/testutils/test_utils.go Refactor SetUpTest: bulk wallet creation/funding, remove helpers
integration-tests/tracetracking/integration_test.go Swap fmt.Printf for t.Logf, adjust imports
integration-tests/tracetracking/.env.example Remove sample environment variable
integration-tests/go.mod Bump chainlink-testing-framework version
.github/workflows/relayer-build.yml Increase Go test parallelism (-p=3)
Comments suppressed due to low confidence (2)

integration-tests/utils/chain.go:168

  • [nitpick] The variable name 'rterr' is ambiguous; consider renaming it to 'cleanupErr' or reusing 'err' for consistency and clarity.
		rterr := framework.RemoveTestContainers()

integration-tests/tracetracking/testutils/test_utils.go:30

  • The loop 'for i := range fundedAccountsCount' tries to iterate over an integer rather than a slice. Use a traditional for loop like 'for i := uint(0); i < fundedAccountsCount; i++' or range over a slice (e.g., 'for i := range recipients').
	for i := range fundedAccountsCount {

Copy link
Collaborator

@patricios-space patricios-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

krebernisak
krebernisak previously approved these changes Jul 15, 2025
accounts = make([]tracetracking.SignedAPIClient, fundedAccountsCount)
for i := range fundedAccountsCount {
accounts[i] = createAndFundWallet(t, api, funder, initialCoinAmount)
w := testutils.CreateTonWallet(t, api, wallet.V3R2, wallet.WithWorkchain(0))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
w := testutils.CreateTonWallet(t, api, wallet.V3R2, wallet.WithWorkchain(0))
w := testutils.CreateRandomTonWallet(t, api, wallet.V3R2, wallet.WithWorkchain(0))

@jadepark-dev jadepark-dev dismissed stale reviews from krebernisak and patricios-space via 2cb7daf July 15, 2025 12:26
@jadepark-dev jadepark-dev enabled auto-merge (squash) July 15, 2025 12:32
@jadepark-dev jadepark-dev merged commit 3a29b2d into main Jul 15, 2025
18 checks passed
@jadepark-dev jadepark-dev deleted the jade/ctf-tvm-11 branch July 15, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants