-
Notifications
You must be signed in to change notification settings - Fork 4
Update Mylocalton with TVM 11 support, Test cleaning up #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates MyLocalTon support to TVM 11, cleans up tracing tests, and optimizes test execution.
- Add
CustomEnvsettings for TVM version and block delay inCreateAPIClient - Refactor
SetUpTestto bulk-create and fund wallets, removing legacy seed-based helpers - Replace
fmt.Printfwitht.Logfacross integration tests and increase test parallelism
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| integration-tests/utils/chain.go | Configure TVM-11 and block delay via CustomEnv, rename cleanup var |
| integration-tests/tracetracking/testutils/test_utils.go | Refactor SetUpTest: bulk wallet creation/funding, remove helpers |
| integration-tests/tracetracking/integration_test.go | Swap fmt.Printf for t.Logf, adjust imports |
| integration-tests/tracetracking/.env.example | Remove sample environment variable |
| integration-tests/go.mod | Bump chainlink-testing-framework version |
| .github/workflows/relayer-build.yml | Increase Go test parallelism (-p=3) |
Comments suppressed due to low confidence (2)
integration-tests/utils/chain.go:168
- [nitpick] The variable name 'rterr' is ambiguous; consider renaming it to 'cleanupErr' or reusing 'err' for consistency and clarity.
rterr := framework.RemoveTestContainers()
integration-tests/tracetracking/testutils/test_utils.go:30
- The loop 'for i := range fundedAccountsCount' tries to iterate over an integer rather than a slice. Use a traditional for loop like 'for i := uint(0); i < fundedAccountsCount; i++' or range over a slice (e.g., 'for i := range recipients').
for i := range fundedAccountsCount {
patricios-space
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
| accounts = make([]tracetracking.SignedAPIClient, fundedAccountsCount) | ||
| for i := range fundedAccountsCount { | ||
| accounts[i] = createAndFundWallet(t, api, funder, initialCoinAmount) | ||
| w := testutils.CreateTonWallet(t, api, wallet.V3R2, wallet.WithWorkchain(0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| w := testutils.CreateTonWallet(t, api, wallet.V3R2, wallet.WithWorkchain(0)) | |
| w := testutils.CreateRandomTonWallet(t, api, wallet.V3R2, wallet.WithWorkchain(0)) |
2cb7daf
Note:
NEXT_BLOCK_GENERATION_DELAYfrom 2(default) to 0.5t.Parallel()causes transactions not being confirmed(not applied)