Skip to content

Conversation

@jmank88
Copy link
Contributor

@jmank88 jmank88 commented Sep 27, 2024

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@jmank88 jmank88 force-pushed the BCF-3361-prom-beholder branch from 22034cb to 70bf492 Compare September 27, 2024 17:30
@cl-sonarqube-production
Copy link

@github-actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 27, 2024
@github-actions github-actions bot closed this Dec 4, 2024
@jmank88 jmank88 removed the Stale label Dec 23, 2024
@jmank88 jmank88 reopened this Dec 23, 2024
@pkcll pkcll force-pushed the BCF-3361-prom-beholder branch from da43461 to 91e9b53 Compare January 29, 2025 16:05
@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025

AER Report: CI Core

aer_workflow , commit , Scheduled Run Frequency , Detect Changes , Clean Go Tidy & Generate , test-scripts , GolangCI Lint (.) , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. CSA key does not exist: go_core_tests_integration

Source of Error:
logger.go:146: 2025-02-13T05:22:10.600Z ERROR chainlink/application.go:860 [Feeds Service] Failed to start CSA key does not exist {"version": "unset@unset"}
github.com/smartcontractkit/chainlink/v2/core/services/chainlink.(*ChainlinkApplication).Start
    /home/runner/work/chainlink/chainlink/core/services/chainlink/application.go:860
github.com/smartcontractkit/chainlink/v2/core/internal/cltest.(*TestApplication).Start
    /home/runner/work/chainlink/chainlink/core/internal/cltest/cltest.go:625
github.com/smartcontractkit/chainlink/v2/core/web_test.TestHealthController_Health_body.func1
    /home/runner/work/chainlink/chainlink/core/web/health_controller_test.go:142
testing.tRunner
    /opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1690

Why: The error indicates that the Feeds Service failed to start because the required CSA (Chainlink Service Agreement) key does not exist in the configuration or environment.

Suggested fix: Ensure that the CSA key is properly configured and available in the environment where the tests are being run. This may involve setting the correct environment variables or updating the configuration files.

2. Health check mismatch: go_core_tests_integration

Source of Error:
logger.go:146: 2025-02-13T05:22:10.685Z ERROR chainlink/application.go:860 [Feeds Service] Failed to start CSA key does not exist {"version": "unset@unset"}
logger.go:146: 2025-02-13T05:22:10.684Z DEBUG web/router.go:531 GET /health {"version": "unset@unset", "method": "GET", "status": 207, "path": "/health", "ginPath": "/health", "query": "failing=", "body": "", "clientIP": "127.0.0.1", "errors": "", "servedAt": "2025-02-13 05:22:10", "latency": "43.261µs"}
health_controller_test.go:156: 
    Error Trace:    /home/runner/work/chainlink/chainlink/core/web/health_controller_test.go:156
    Error:          Not equal: 
                    expected: "! EVM.0.HeadTracker.HeadListener\n\tListener is not connected"
                    actual  : "! EVM.0.HeadTracker.HeadListener\n\tListener is not connected\n! PromOTELForwarder\n\tservice is \"Unstarted\", not started"
                    
                    Diff:
                    --- Expected
                    +++ Actual
                    @@ -2 +2,3 @@
                      Listener is not connected
                    +! PromOTELForwarder
                    +    service is "Unstarted", not started
    Test:           TestHealthController_Health_body/text-failing

Why: The health check test is failing because the actual output contains an additional error message about the "PromOTELForwarder" service being "Unstarted", which was not expected.

Suggested fix: Update the expected output in the test to include the "PromOTELForwarder" service status, or ensure that the "PromOTELForwarder" service is started correctly before running the health check.

3. Comment formatting issue: lint

Source of Error:
logger.go:146: 2025-02-13T05:23:37.9822741Z ##[error]core/services/promotel/promotel.go:72:4: commentFormatting: put a space between `//` and comment text (gocritic)
logger.go:146: 2025-02-13T05:23:37.9823804Z //TODO f.meterProvider.Meter()
logger.go:146: 2025-02-13T05:23:37.9824292Z ^

Why: The linter has detected a comment formatting issue where there is no space between // and the comment text.

Suggested fix: Add a space between // and the comment text in the specified file. Change //TODO f.meterProvider.Meter() to // TODO f.meterProvider.Meter().

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@pkcll pkcll force-pushed the BCF-3361-prom-beholder branch from 202e8c8 to fe16cad Compare February 13, 2025 05:17
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

@github-actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 16, 2025
@github-actions github-actions bot closed this Apr 26, 2025
@github-actions github-actions bot deleted the BCF-3361-prom-beholder branch April 26, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants