Updated EVM Write target to use Generalized WT framework #17118

silaslenihan · 2025-04-04T15:42:14Z

Requires

Supports

github-actions · 2025-04-04T15:43:20Z

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

github-actions · 2025-04-04T16:04:03Z

Flakeguard Summary

Ran new or updated tests between develop and f87d5c3e915e6c79e2bbc9ad8214895718e45ced (evm-write-target-generalization).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
TestEvmWrite/succeeds_with_valid_report	0%	false	false	false	3	0	3	0	github.com/smartcontractkit/chainlink/v2/core/services/relay/evm	false	16.666666ms	Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Signed-off-by: Silas Lenihan <[email protected]>

github-actions · 2025-04-07T15:41:41Z

Flakeguard Summary

Ran new or updated tests between develop and 25a6f9712b43849376fa5ae01a0bad5489be2a73 (evm-write-target-generalization).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
TestEvmWrite	0%	true	false	false	3	0	3	0	github.com/smartcontractkit/chainlink/v2/core/services/relay/evm	true	0s	Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

core/services/relay/evm/target_strategy.go

core/services/relay/evm/write_target.go

dhaidashenko

LGTM. My only concern is the change in behaviour where success is returned right after a transaction is accepted by TXM. If Workflow DON sends report to the next Node right after that there is a high chance that multiple reports will be accepted.

github-actions · 2025-04-07T17:23:06Z

Flakeguard Summary

Ran new or updated tests between develop and cbe17b9439a5c90ddbc476fd3aaa1d48d09c4590 (evm-write-target-generalization).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
TestEvmWrite/fails_when_TXM_CreateTransaction_returns_error	0%	false	false	false	3	0	3	0	github.com/smartcontractkit/chainlink/v2/core/services/relay/evm	false	20ms	Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

core/services/relay/evm/write_target.go

cl-sonarqube-production · 2025-04-08T18:29:35Z

Quality Gate passed

Issues
7 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

)" This reverts commit 654c21e.

* Updated EVM Write target to use Generalized WT framework Signed-off-by: Silas Lenihan <[email protected]> * removed old EVM write target and tests * updated query transmission state * Feedback comments * Addressed feedback * bumped go.mod * Fixed go.mod dependencies * fixed dependency issues * updated chainlink-framework refs to chainlink-evm * bumped go.mod * addressed feedback --------- Signed-off-by: Silas Lenihan <[email protected]>

)" This reverts commit 654c21e.

* Revert "Updated EVM Write target to use Generalized WT framework (#17118)" This reverts commit 654c21e. * Fixed linting

* Bump version and update CHANGELOG for core v2.23.0 * CCIP - Implement token pricing interface for PipelinePriceGetter (#17202) * token pricing pipeline * remove deprecated tags since linter doesn't like it * Fixing telemetry bug (#17208) * core/capabilities/ccip: correct telem type in monitor endpoint (#17219) * core/capabilities/ccip: correct telem type in monitor endpoint * don't panic * switch to require * Update solana ref to pull in 3 changes needed for 2.23 (#17237) * Update solana ref to pull in CR race fix & lookback feature * Update docs for Solana config * Update tests * pnpm changeset * make config-docs * Update solana ref * Added new config for Solana block history estimator * Updated chainlink-solana commit * Upgraded chainlink-solana dependency --------- Co-authored-by: amit-momin <[email protected]> * Revert "Updated EVM Write target to use Generalized WT framework (#17118)" This reverts commit 654c21e. * newline * fixed lint issues * Backport: bump chainlink-solana to fix nested CPI event parsing issue (#17273) * Bump chainlink-solana to fix CR namespace issue * make modgraph * patch * chore: replace prom/common with v0.62.0 * fix: bump chain selectors to v1.0.52 * chore: add changeset * chore: capitalize * chore: add tag to changeset * Finalize date on changelog for 2.23.0 * Update go.mod, bump chain-selectors * make tidy and make modgraph Signed-off-by: bwest981 <[email protected]> * Accept develop package.json to resolve conflict --------- Signed-off-by: bwest981 <[email protected]> Co-authored-by: gheorghestrimtu <[email protected]> Co-authored-by: dimitris <[email protected]> Co-authored-by: Mateusz Sekara <[email protected]> Co-authored-by: Andrés Juliá <[email protected]> Co-authored-by: Makram <[email protected]> Co-authored-by: Domino Valdano <[email protected]> Co-authored-by: amit-momin <[email protected]> Co-authored-by: Silas Lenihan <[email protected]> Co-authored-by: Blaž Hrastnik <[email protected]> Co-authored-by: Chris De Leon <[email protected]>

* Updated EVM Write target to use Generalized WT framework Signed-off-by: Silas Lenihan <[email protected]> * removed old EVM write target and tests * updated query transmission state * Feedback comments * Addressed feedback * bumped go.mod * Fixed go.mod dependencies * fixed dependency issues * updated chainlink-framework refs to chainlink-evm * bumped go.mod * addressed feedback --------- Signed-off-by: Silas Lenihan <[email protected]>

* Added df decoder injection to EVM WT * Added EVM specific dfProcessor to write target * Moved dfProcessor to chainlink-evm * updated go.mod and locations * Updated WT to use product specific processor * Refactored to use common Metadata type * Updated GenerateWriteTargetName to use generalized NewWriteTargetID * Updated EVM WT tests to pass in processor via config * Updated WT imports from chainlink-evm to chainlink-framework * Updated EVM Write target to use Generalized WT framework (#17118) * Updated EVM Write target to use Generalized WT framework Signed-off-by: Silas Lenihan <[email protected]> * removed old EVM write target and tests * updated query transmission state * Feedback comments * Addressed feedback * bumped go.mod * Fixed go.mod dependencies * fixed dependency issues * updated chainlink-framework refs to chainlink-evm * bumped go.mod * addressed feedback --------- Signed-off-by: Silas Lenihan <[email protected]> * Updated to latest version * Updated tests to wait for Beholder emits for greater coverage, also added CCIP test case * updated to latest chainlink-framework version and fixed tests * bumped go.mod * bumped go.mod and fixed broken merges * Added support for POR Reports * bumped go.mod * lint fix * Updated WT polling to be configurable * Added config defaults to testdata * Removed EVMService and ContractReader * changed default TxAcceptanceState to 2 * removed GasEstimator from NewChainOpts * fixed tests and lint * Updated for new processor structure * updated to latest versions * Remove trailing brace in config --------- Signed-off-by: Silas Lenihan <[email protected]>

silaslenihan requested review from a team as code owners April 4, 2025 15:42

silaslenihan requested a review from cedric-cordenier April 4, 2025 15:42

silaslenihan marked this pull request as draft April 4, 2025 15:42

Updated EVM Write target to use Generalized WT framework

d85f1b1

Signed-off-by: Silas Lenihan <[email protected]>

silaslenihan force-pushed the evm-write-target-generalization branch from e0e1cb3 to 1b56808 Compare April 4, 2025 21:37

removed old EVM write target and tests

771b1d3

silaslenihan force-pushed the evm-write-target-generalization branch from 1b56808 to 771b1d3 Compare April 4, 2025 22:08

silaslenihan marked this pull request as ready for review April 4, 2025 22:19

silaslenihan requested review from a team as code owners April 4, 2025 22:19

Merge branch 'develop' into evm-write-target-generalization

211d580

silaslenihan force-pushed the evm-write-target-generalization branch 3 times, most recently from e815d72 to 25a6f97 Compare April 7, 2025 15:27

silaslenihan force-pushed the evm-write-target-generalization branch 3 times, most recently from 1c34068 to 3a7d2de Compare April 7, 2025 15:53

Merge branch 'develop' into evm-write-target-generalization

e22a3f0

silaslenihan force-pushed the evm-write-target-generalization branch from 3a7d2de to e22a3f0 Compare April 7, 2025 16:01

updated query transmission state

f90cd95

dhaidashenko reviewed Apr 7, 2025

View reviewed changes

core/services/relay/evm/target_strategy.go Outdated Show resolved Hide resolved

core/services/relay/evm/target_strategy.go Outdated Show resolved Hide resolved

core/services/relay/evm/write_target.go Show resolved Hide resolved

dhaidashenko reviewed Apr 7, 2025

View reviewed changes

Feedback comments

0ade87b

silaslenihan mentioned this pull request Apr 7, 2025

Extracted Generalized Aptos monitoring packages to common smartcontractkit/chainlink-common#1107

Closed

krebernisak previously approved these changes Apr 8, 2025

View reviewed changes

silaslenihan dismissed krebernisak’s stale review via 036dff1 April 8, 2025 17:36

silaslenihan force-pushed the evm-write-target-generalization branch 4 times, most recently from 09b120e to ddaac8a Compare April 8, 2025 18:05

krebernisak reviewed Apr 8, 2025

View reviewed changes

core/services/relay/evm/write_target.go Outdated Show resolved Hide resolved

addressed feedback

315aa1d

silaslenihan force-pushed the evm-write-target-generalization branch from ddaac8a to 315aa1d Compare April 8, 2025 18:16

krebernisak approved these changes Apr 8, 2025

View reviewed changes

silaslenihan requested review from dhaidashenko and jmank88 April 8, 2025 18:20

jmank88 approved these changes Apr 8, 2025

View reviewed changes

dhaidashenko approved these changes Apr 8, 2025

View reviewed changes

jmank88 enabled auto-merge April 8, 2025 18:43

krehermann approved these changes Apr 8, 2025

View reviewed changes

jmank88 added this pull request to the merge queue Apr 8, 2025

Merged via the queue into develop with commit 654c21e Apr 8, 2025
177 of 178 checks passed

jmank88 deleted the evm-write-target-generalization branch April 8, 2025 19:16

gheorghestrimtu added a commit that referenced this pull request Apr 14, 2025

Revert "Updated EVM Write target to use Generalized WT framework (#17118

f3b5eac

)" This reverts commit 654c21e.

silaslenihan added a commit that referenced this pull request May 2, 2025

Revert "Updated EVM Write target to use Generalized WT framework (#17118

3e18f4b

)" This reverts commit 654c21e.

github-merge-queue bot pushed a commit that referenced this pull request May 5, 2025

Removed Generalized Write Target (#17560)

2d7a5c9

* Revert "Updated EVM Write target to use Generalized WT framework (#17118)" This reverts commit 654c21e. * Fixed linting

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updated EVM Write target to use Generalized WT framework #17118

Updated EVM Write target to use Generalized WT framework #17118

Uh oh!

silaslenihan commented Apr 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhaidashenko left a comment

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

Uh oh!

cl-sonarqube-production bot commented Apr 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Updated EVM Write target to use Generalized WT framework #17118

Updated EVM Write target to use Generalized WT framework #17118

Uh oh!

Conversation

silaslenihan commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Requires

Supports

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

github-actions bot commented Apr 4, 2025

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

Uh oh!

github-actions bot commented Apr 7, 2025

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhaidashenko left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 7, 2025

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

Uh oh!

Uh oh!

cl-sonarqube-production bot commented Apr 8, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

silaslenihan commented Apr 4, 2025 •

edited

Loading