Skip to content

HeadTracker PersistenceBatchSize #18656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilija42 merged 26 commits into from
Jul 17, 2025
Merged

HeadTracker PersistenceBatchSize #18656

ilija42 merged 26 commits into from
Jul 17, 2025

Conversation

@yashnevatia
Copy link
Contributor

@yashnevatia yashnevatia commented Jul 16, 2025 •
edited
Loading

@yashnevatia yashnevatia requested review from a team as code owners July 16, 2025 09:27
@yashnevatia yashnevatia requested a review from mchain0 July 16, 2025 09:27
@yashnevatia yashnevatia marked this pull request as draft July 16, 2025 09:27
@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025

👋 yashnevatia, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@yashnevatia yashnevatia changed the title batch=0, add logic to trim only HeadTracker PersistenceBatchSize Jul 17, 2025
pablolagreca
pablolagreca previously approved these changes Jul 17, 2025
View reviewed changes
@yashnevatia yashnevatia marked this pull request as ready for review July 17, 2025 14:10
@yashnevatia yashnevatia requested review from a team as code owners July 17, 2025 14:10
pablolagreca
pablolagreca previously approved these changes Jul 17, 2025
View reviewed changes
@yashnevatia yashnevatia marked this pull request as draft July 17, 2025 14:38
@yashnevatia yashnevatia marked this pull request as ready for review July 17, 2025 14:52
@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Jul 17, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@yashnevatia yashnevatia requested a review from pablolagreca July 17, 2025 14:57
@ilija42 ilija42 enabled auto-merge July 17, 2025 15:31
@ilija42 ilija42 added this pull request to the merge queue Jul 17, 2025
Merged via the queue into develop with commit d9cffa2 Jul 17, 2025
156 of 157 checks passed
@ilija42 ilija42 deleted the ht-db branch July 17, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winder winder winder approved these changes

@DylanTinianov DylanTinianov DylanTinianov approved these changes

@dhaidashenko dhaidashenko dhaidashenko approved these changes

@ilija42 ilija42 ilija42 approved these changes

@mchain0 mchain0 Awaiting requested review from mchain0 mchain0 is a code owner automatically assigned from smartcontractkit/foundations

@Tofel Tofel Awaiting requested review from Tofel

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@matYang matYang Awaiting requested review from matYang matYang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@AmrMohamedRezk AmrMohamedRezk Awaiting requested review from AmrMohamedRezk AmrMohamedRezk is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami is a code owner automatically assigned from smartcontractkit/ccip-offchain

@wentzeld wentzeld Awaiting requested review from wentzeld

+1 more reviewer

@pablolagreca pablolagreca pablolagreca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yashnevatia @winder @pablolagreca @DylanTinianov @dhaidashenko @ilija42