-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: update standalone engine to take workflow limit settings #20755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update standalone engine to take workflow limit settings #20755
Conversation
|
I see you updated files related to
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for configuring workflow execution to permit all chains when running the standalone CRE engine. It introduces a new --allChains command-line flag that allows users to bypass chain restrictions during testing.
Key changes:
- Added
--allChainsCLI flag to enable all chains during workflow execution - Propagated workflow settings configuration through the runner and engine initialization chain
- Updated
NewStandaloneEngineto accept and apply workflow settings configuration
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
core/services/workflows/cmd/cre/main.go |
Added --allChains flag and configuration function to pass chain settings to the runner |
core/services/workflows/cmd/cre/utils/runner.go |
Added WorkflowSettingsCfgFn field to RunnerConfig and propagated it to engine creation |
core/services/workflows/cmd/cre/utils/standalone_engine.go |
Updated NewStandaloneEngine signature to accept and use workflow settings configuration function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.




DEVSVCS-3469
This pull request adds support for enabling all chains during workflow execution using standalone engine. It introduces a new command-line flag and propagates the configuration through the workflow runner and engine setup, allowing the workflow to permit all chains when the flag is set. This is now required since #20548
Feature: Enable all chains for workflow execution
--allChainsflag to thecrecommand-line tool, allowing users to enable all chains during workflow execution for testing purposes. [1] [2]WorkflowSettingsCfgFnfunction through the runner and engine setup to configure per-chain settings accordingly. [1] [2] [3] [4]Internal: Dependency and configuration propagation
cresettingsand related settings packages in relevant files to support the new configuration logic. [1] [2] [3]WorkflowSettingsCfgFnfor setting up chain permissions, ensuring that the--allChainsflag is respected during workflow execution.Requires
Supports