Skip to content

Conversation

@shileiwill
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

👋 shileiwill, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

2025-12-08T10:32:11Z [USER LOG] msg="MVR bundle read" chain=ethereum-mainnet-base-1 feed="S&P Global SSA EURC" address=0xcF99622B5440a338f45daEE134d531A4BE64251F lastModifiedDateTimeRaw=1737072000 lastModifiedDateTimeRFC3339=2025-01-17T00:00:00Z securityId=SP-EURC securityName=EURC ssaRaw=2 ssaScaled=2 ssaDesc=Strong ssaDecimal=0

Workflow Simulation Result:
"[{\"name\":\"S\\u0026P Global SSA EURC\",\"address\":\"0xcF99622B5440a338f45daEE134d531A4BE64251F\",\"bundle\":{\"lastModifiedDateTimeRaw\":\"1737072000\",\"lastModifiedDateTimeRfc3339\":\"2025-01-17T00:00:00Z\",\"securityId\":\"SP-EURC\",\"securityName\":\"EURC\",\"ssaRaw\":\"2\",\"ssaScaled\":\"2\",\"ssaDesc\":\"Strong\",\"ssaDecimal\":0},\"bundleDecimals\":\"AAAAAAA=\"}]"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: is this really the output format?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, this is the real one.

contracts/evm/src/generated/bundle_aggregator_proxy/...
```

After generation, if your module picked up new deps, run:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'm not sure there is an upside to shortening 'dependencies' to 'deps' and this may create some confusion with the less technical consumer

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call. if it is okay, i will keep it as is since deps was used in multiple places already and hope the go devs know dependencies. I will definitely pay attention to the future writings.

@shileiwill shileiwill merged commit 19944f2 into main Dec 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants