-
Notifications
You must be signed in to change notification settings - Fork 11
add 2 use cases to template #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 QingyangKong, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QingyangKong should we update this README (inside cre-templates repo only) to say that the canonical (ie fully devrel maintained) version will be the original repo? we want to retain AI / Google searchability on the repo URLs and we also want to maintain just one codebase.
Same for the tokenized-asset-saving main README
timothyF95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave a brief scan and I can stamp on behalf of Dev-Svc but if you need a thorough review, will take me some time.
| # Private Key (with 0x prefix, 64 hex characters) | ||
| # DUMMY KEY BELOW - For dry run only (Hardhat test account #0) | ||
| # For live testing: Replace with YOUR private key that has Sepolia ETH | ||
| CRE_ETH_PRIVATE_KEY=0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging potential PK leak
Would recommend:
0x0000000000000000000000000000000000000000000000000000000000000000
to avoid confusion/mistakes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching!!
this PK is derived from the test test test .... junk mnemonic widely used for anvil's default accounts:
https://getfoundry.sh/anvil/overview/#getting-started @timothyF95
so safe.
@woogieboogie-jl we should change the env var name. It should be descriptive of this being a default/dummy PK. That is of educational value to new web3 des.
| local-simulation: | ||
| rpcs: | ||
| - chain-name: ethereum-testnet-sepolia | ||
| url: https://por.bcy-p.metalhosts.com/cre-alpha/MvqtrdftrbxcP3ZgGBJb3bK5/ethereum/sepolia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging potential API KEY ?
|
|
||
| async function main() { | ||
|
|
||
| const RPC_URL = 'https://por.bcy-p.metalhosts.com/cre-alpha/MvqtrdftrbxcP3ZgGBJb3bK5/ethereum/sepolia' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging potential API KEY
|
No description provided.