Revert spinner to fix telepresence clientside apply step#5
Conversation
|
👋 scheibinger, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes to the spinner functionality in the client-side apply component to fix a bug where telepresence client-side apply was unable to prompt for user admin password. The removal of combined output handling in the spinner restored the ability for interactive prompts to work properly.
- Removes spinner progress indication from command execution
- Restores proper stdout/stderr streaming for interactive commands
- Eliminates spinner configuration and related dependencies
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/adapter/clientsideapply/cmd.go | Removes spinner usage and restores proper I/O handling for interactive commands |
| internal/adapter/clientsideapply/client_side_apply.go | Removes spinner configuration and yacspin dependency |
| import ( | ||
| "context" | ||
| "fmt" | ||
| "io" |
There was a problem hiding this comment.
The io import is added but consider if all spinner-related cleanup was properly handled. Verify that no orphaned references to spinner functionality remain in other parts of the codebase.
Adding combined output in the spinner, broke the telepresence client side apply which was prompting for the user admin password.
It was showing the error below: