-
Notifications
You must be signed in to change notification settings - Fork 8
Add ws heartbeat #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ws heartbeat #642
Conversation
|
👋 mxiao-cll, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
NPM Publishing labels 🏷️🟢 This PR has valid version labels and will cause a |
|
Can you add something in the PR description about how you've tested this in an actual EA? |
mohamed-mehany
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me.
However, was wondering if we should also add a ping handler since WS servers usually already send regular pings, and would be nice to be able to use that handler to keep the WS connection alive and prevent the framework from closing the connection?
You mean a handler to handle ping events sent by the WS server? We can add that, but for this one I have a use case where a specific message needs to be sent to server to keep connection open. |
|
🚀 Successfully created version bump PR: #641 |
Add ability for EA to send heartbeat to ws server
Tested this on dxFeed EA and verified that regular heartbeat was sent periodically