Skip to content

Conversation

@mxiao-cll
Copy link
Contributor

@mxiao-cll mxiao-cll commented Dec 8, 2025

Add ability for EA to send heartbeat to ws server

Tested this on dxFeed EA and verified that regular heartbeat was sent periodically

@mxiao-cll mxiao-cll requested a review from a team as a code owner December 8, 2025 19:23
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

👋 mxiao-cll, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

NPM Publishing labels 🏷️

🟢 This PR has valid version labels and will cause a patch bump.

@mxiao-cll mxiao-cll added the patch label Dec 8, 2025
@dskloetc
Copy link
Contributor

dskloetc commented Dec 9, 2025

Can you add something in the PR description about how you've tested this in an actual EA?

Copy link

@mohamed-mehany mohamed-mehany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.
However, was wondering if we should also add a ping handler since WS servers usually already send regular pings, and would be nice to be able to use that handler to keep the WS connection alive and prevent the framework from closing the connection?

@mxiao-cll
Copy link
Contributor Author

Code looks good to me. However, was wondering if we should also add a ping handler since WS servers usually already send regular pings, and would be nice to be able to use that handler to keep the WS connection alive and prevent the framework from closing the connection?

You mean a handler to handle ping events sent by the WS server? We can add that, but for this one I have a use case where a specific message needs to be sent to server to keep connection open.

@mxiao-cll mxiao-cll merged commit dae947f into main Dec 9, 2025
14 checks passed
@mxiao-cll mxiao-cll deleted the hb branch December 9, 2025 15:34
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

🚀 Successfully created version bump PR: #641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants