Clear wsSubscriptionActive metrics when wss disconnent #643
Conversation
|
👋 mxiao-cll, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
NPM Publishing labels 🏷️🟢 This PR has valid version labels and will cause a |
src/transports/websocket.ts
Outdated
|
|
||
| if (subscriptions.desired.length) { | ||
| // Clear wsSubscriptionActive metrics for all active subscriptions | ||
| recordWsMessageMetrics(context, [], subscriptions.desired, false) |
There was a problem hiding this comment.
Side note: This streamHandler is really long and hard to read. Do you think it would make sense to split up into multiple functions?
There was a problem hiding this comment.
I agree, but not sure how to make that happen, I can put in a TODO and create a ticket but I doubt it would be picked up.
I would've done if not code freeze
|
🚀 Successfully created version bump PR: #644 |
2 participants
When we close a ws connection, we don't clear
ws_subscription_activevalue, so if you keep connect and dis-connect, you would see a large number but actually you only have 1 connection open