Skip to content

Conversation

@dskloetc
Copy link
Contributor

@dskloetc dskloetc commented Nov 24, 2025

Description

When data-engine was released in #4309 it should have released glv-token as well because it depends on data-engine, and so it should have received a patch version bump.

But this wasn't caught by the get-changeset-arguments.sh because the dependency is on workspace:^ while the script specifically searches for workspace:*.

I also found some dependencies on just *.

$ git grep -h '@chainlink[^"]*": "' '**/package.json' | sed -e 's@.*":@@' | sort -u
 "*",
 "1.2.0",
 "2.10.0",
 "2.11.0",
 "2.8.0",
 "^0.8.0",
 "^2.8.0",
 "workspace:*",
 "workspace:^",

Changes

Search for any dependencies on the given package.

Steps to Test

glv-token is now included (when checked out at a63b398fd7394a9349b620cba4902a8a69a7b2c4):

$ .github/scripts/get-changeset-arguments.sh data-engine > /dev/null
Not ignoring the following transitive dependencies:
@chainlink/data-engine-adapter
@chainlink/data-streams-sdk
@chainlink/external-adapter-framework
@chainlink/glv-token-adapter

Expecting the following packages to be released:
@chainlink/data-engine-adapter
@chainlink/glv-token-adapter

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2025

⚠️ No Changeset found

Latest commit: aa8b5da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dskloetc dskloetc marked this pull request as ready for review November 24, 2025 15:31
@dskloetc dskloetc enabled auto-merge (squash) November 24, 2025 15:35
@dskloetc dskloetc merged commit 95af4ec into main Nov 24, 2025
16 checks passed
@dskloetc dskloetc deleted the kloet/workspace-dep branch November 24, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants