Conversation
🦋 Changeset detectedLatest commit: 4f0fb9e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8fd0c90 to
e05640d
Compare
|
Silly q: since it's a new EA shouldn't we just bump to the latest framework version? |
We can definitely bump it but I didn't think it was worth the extra effort. Let me know what you want. |
|
Might as well bump to latest FW version and sanity check/rerun tests. If you encounter any issues or uncertainty, feel free to revert to this working version. |
|
A couple comments/suggestions, mostly small. Bigger ones:
|
I've started a Slack thread.
I don't know what this is referring to. |
It will just be derived from |
OPDATA-6440
Description
iTick is a provider of market data. They provide websocket and rest APIs.
We need to use different API keys for data from different regions (such as Hong Kong, Korea, etc.) so to avoid managing multiple websockets per endpoint we implement separate endpoints for separate regions.
We want to provide bid/ask/mid data as well as last price data for various stocks and indices.
bid/ask data from from a different API than last price data so we also provide these through different endpoints.
Indices are all considered to be from the
gbregion even though they come from all over the world.We'll probably only be using the websocket transports but having the HTTP transports helped with testing (because the websocket API doesn't provide data when the markets are closed) and so I just left them in for convenience.
Changes
depthendpoints andquoteendpoints.httpandwstransports used in generated endpoints.Steps to Test
yarn test packages/sources/itick/test/integration/Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.