[DF-22956] ensure tiingo request transform executes by removing factory wrapper#4778
[DF-22956] ensure tiingo request transform executes by removing factory wrapper#4778
Conversation
🦋 Changeset detectedLatest commit: b0e9980 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cl-efornaciari
left a comment
There was a problem hiding this comment.
one question, also needs to be rebased
| }) | ||
|
|
||
| it('lowercases base-only requests without a quote', () => { | ||
| const requestContextData = { base: 'AaPl' } |
There was a problem hiding this comment.
Is this an actual case? is this assumed to be USD?
.changeset/funny-keys-yell.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@chainlink/tiingo-adapter': major | |||
There was a problem hiding this comment.
Should this update tiingo-state as well?
There was a problem hiding this comment.
For major bump always include details on that what is breaking and how should NOP handle it
There was a problem hiding this comment.
i downgraded it patch
changeset won't list tiingo-state as option, i think in this PR it is implicitly modified
| '@chainlink/por-address-list-adapter': patch | ||
| '@chainlink/tiingo-adapter': patch | ||
| '@chainlink/itick-adapter': patch |
There was a problem hiding this comment.
This makes no sense, you only updated tiingo
| expect(req.requestContext.data).toBe(requestContextData) | ||
| expect(req.requestContext.data).toEqual({ base: 'eth', quote: 'usd' }) |
There was a problem hiding this comment.
I don't understand what toBe is doing here
Closes #DF-22956
Description
Refactor tiingoCommonSubscriptionRequestTransform from a factory function to a direct request transform to align with the AdapterEndpoint contract.
Changes
Before
After
Steps to Test
Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.