feat: add timelock converter and inspector helpers #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo <[email protected]>
🦋 Changeset detectedLatest commit: 359c64a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Pablo <[email protected]>
Signed-off-by: Pablo <[email protected]>
Signed-off-by: Pablo <[email protected]>
Signed-off-by: Pablo <[email protected]>
Update the push main workflow to mimick the pr checks workflow. They were not in sync. As future enhancement we can extract this into a separate reusable action that can be reused in both Signed-off-by: Pablo <[email protected]>
Supports and extracted from #486
#556) Bumps [@changesets/changelog-github](https://github.com/changesets/changesets) from 0.5.0 to 0.5.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/changesets/changesets/releases"><code>@changesets/changelog-github</code>'s releases</a>.</em></p> <blockquote> <h2><code>@changesets/changelog-github</code><a href="https://github.com/0"><code>@0</code></a>.5.1</h2> <h3>Patch Changes</h3> <ul> <li>Updated dependencies [<a href="https://github.com/changesets/changesets/commit/84a4a1b1d399bfd0a58677b0182b9c053194febf"><code>84a4a1b</code></a>]: <ul> <li><code>@changesets/types</code><a href="https://github.com/6"><code>@6</code></a>.1.0</li> </ul> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/changesets/changesets/commit/4f8d76c225e4b9cffa764548c49e0ef2aee2a2af"><code>4f8d76c</code></a> Version Packages (<a href="https://redirect.github.com/changesets/changesets/issues/670">#670</a>)</li> <li><a href="https://github.com/changesets/changesets/commit/d8f0e6851bddf307b70b03e23b50e0b9410aafa7"><code>d8f0e68</code></a> Fixed an issue with parsing <code>--json</code> output when publishing (<a href="https://redirect.github.com/changesets/changesets/issues/676">#676</a>)</li> <li><a href="https://github.com/changesets/changesets/commit/fe8db7500f81caea9064f8bec02bcb77e0fd8fce"><code>fe8db75</code></a> Upgrade <code>@manypkg/get-packages</code> dependencies to latest version (<a href="https://redirect.github.com/changesets/changesets/issues/667">#667</a>)</li> <li><a href="https://github.com/changesets/changesets/commit/9a993ba09629c1620d749432520470cec49d3a96"><code>9a993ba</code></a> Add <code>resolutions</code> to the <code>PackageJSON</code> type (<a href="https://redirect.github.com/changesets/changesets/issues/668">#668</a>)</li> <li><a href="https://github.com/changesets/changesets/commit/a8c8a03824a6033854d32779ca5fc4e1571016cc"><code>a8c8a03</code></a> Version Packages (<a href="https://redirect.github.com/changesets/changesets/issues/663">#663</a>)</li> <li><a href="https://github.com/changesets/changesets/commit/5413f3e772bf867234922b0691e3c58c1864412d"><code>5413f3e</code></a> Fixed an issue with adding <code>[undefined]</code> to the generated changelog (<a href="https://redirect.github.com/changesets/changesets/issues/660">#660</a>)</li> <li><a href="https://github.com/changesets/changesets/commit/74dda8c0d8bd1741ca7b19f0ccb37b2330dc9549"><code>74dda8c</code></a> Add support for <code>workspace:~</code> and <code>workspace:^</code> (<a href="https://redirect.github.com/changesets/changesets/issues/585">#585</a>)</li> <li><a href="https://github.com/changesets/changesets/commit/2b49c390a7cf24ce859ac932b432eb6d8f55c98b"><code>2b49c39</code></a> Implement <code>changeset tag</code> and <code>getAllTags</code> (<a href="https://redirect.github.com/changesets/changesets/issues/634">#634</a>)</li> <li><a href="https://github.com/changesets/changesets/commit/09a7dab8792fa30ce45a8c751e82db177b09666d"><code>09a7dab</code></a> Make master branch rename suggestion more clear (<a href="https://redirect.github.com/changesets/changesets/issues/638">#638</a>)</li> <li><a href="https://github.com/changesets/changesets/commit/a3628d54aa365140935d6ae376fe6921b221dd5b"><code>a3628d5</code></a> Helpful note about <code>status</code> command (<a href="https://redirect.github.com/changesets/changesets/issues/639">#639</a>)</li> <li>Additional commits viewable in <a href="https://github.com/changesets/changesets/compare/@changesets/[email protected]...@changesets/[email protected]">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# Summary Sui Timelock converter existed, but wasn't integrated into `OperationCounts`. This PR fixes this.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @smartcontractkit/[email protected] ### Minor Changes - [#571](#571) [`141dc6f`](141dc6f) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - chore: bump version Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Changing for consistency across the rest of chain family sdks --------- Signed-off-by: Pablo <[email protected]>
…0.85 to 1.0.89 (#574) Bumps [github.com/smartcontractkit/chain-selectors](https://github.com/smartcontractkit/chain-selectors) from 1.0.85 to 1.0.89. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/smartcontractkit/chain-selectors/releases">github.com/smartcontractkit/chain-selectors's releases</a>.</em></p> <blockquote> <h2>v1.0.89</h2> <h2>What's Changed</h2> <ul> <li>add sonic testnet by <a href="https://github.com/joaoluisam"><code>@joaoluisam</code></a> in <a href="https://redirect.github.com/smartcontractkit/chain-selectors/pull/164">smartcontractkit/chain-selectors#164</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/smartcontractkit/chain-selectors/compare/v1.0.88...v1.0.89">https://github.com/smartcontractkit/chain-selectors/compare/v1.0.88...v1.0.89</a></p> <h2>v1.0.88</h2> <h2>What's Changed</h2> <ul> <li>Add Canton chain selectors by <a href="https://github.com/friedemannf"><code>@friedemannf</code></a> in <a href="https://redirect.github.com/smartcontractkit/chain-selectors/pull/157">smartcontractkit/chain-selectors#157</a></li> <li>add pharos mainnet by <a href="https://github.com/finleydecker"><code>@finleydecker</code></a> in <a href="https://redirect.github.com/smartcontractkit/chain-selectors/pull/162">smartcontractkit/chain-selectors#162</a></li> <li>add adi testnet + mainnet by <a href="https://github.com/finleydecker"><code>@finleydecker</code></a> in <a href="https://redirect.github.com/smartcontractkit/chain-selectors/pull/163">smartcontractkit/chain-selectors#163</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/smartcontractkit/chain-selectors/compare/v1.0.87...v1.0.88">https://github.com/smartcontractkit/chain-selectors/compare/v1.0.87...v1.0.88</a></p> <h2>v1.0.87</h2> <h2>What's Changed</h2> <ul> <li>fix(remote): consolidate duplicate struct by <a href="https://github.com/graham-chainlink"><code>@graham-chainlink</code></a> in <a href="https://redirect.github.com/smartcontractkit/chain-selectors/pull/161">smartcontractkit/chain-selectors#161</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/smartcontractkit/chain-selectors/compare/v1.0.86...v1.0.87">https://github.com/smartcontractkit/chain-selectors/compare/v1.0.86...v1.0.87</a></p> <h2>v1.0.86</h2> <h2>What's Changed</h2> <ul> <li>feat: generate all_selectors.yml by <a href="https://github.com/graham-chainlink"><code>@graham-chainlink</code></a> in <a href="https://redirect.github.com/smartcontractkit/chain-selectors/pull/158">smartcontractkit/chain-selectors#158</a></li> <li>feat: introduce remote chain fetching api by <a href="https://github.com/graham-chainlink"><code>@graham-chainlink</code></a> in <a href="https://redirect.github.com/smartcontractkit/chain-selectors/pull/159">smartcontractkit/chain-selectors#159</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/graham-chainlink"><code>@graham-chainlink</code></a> made their first contribution in <a href="https://redirect.github.com/smartcontractkit/chain-selectors/pull/158">smartcontractkit/chain-selectors#158</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/smartcontractkit/chain-selectors/compare/v1.0.85...v1.0.86">https://github.com/smartcontractkit/chain-selectors/compare/v1.0.85...v1.0.86</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/smartcontractkit/chain-selectors/commit/c03172ea11b37d0fb05179296961023b8613cce5"><code>c03172e</code></a> add sonic testnet (<a href="https://redirect.github.com/smartcontractkit/chain-selectors/issues/164">#164</a>)</li> <li><a href="https://github.com/smartcontractkit/chain-selectors/commit/01f8d6e17b0dcd8a31858f38cf639449257b8de5"><code>01f8d6e</code></a> add adi testnet + mainnet (<a href="https://redirect.github.com/smartcontractkit/chain-selectors/issues/163">#163</a>)</li> <li><a href="https://github.com/smartcontractkit/chain-selectors/commit/5102bafec1cf374b14a415b3dae62bb7e50ce661"><code>5102baf</code></a> add pharos mainnet (<a href="https://redirect.github.com/smartcontractkit/chain-selectors/issues/162">#162</a>)</li> <li><a href="https://github.com/smartcontractkit/chain-selectors/commit/9b78e9fc0d9a9c0cdc8c4ff77d2be7d9b4017cdf"><code>9b78e9f</code></a> Add Canton chain selectors (<a href="https://redirect.github.com/smartcontractkit/chain-selectors/issues/157">#157</a>)</li> <li><a href="https://github.com/smartcontractkit/chain-selectors/commit/9fb0056c9576b83bdcd48ba4dfc6dd11f9f3b816"><code>9fb0056</code></a> fix: consolidate duplicate struct (<a href="https://redirect.github.com/smartcontractkit/chain-selectors/issues/161">#161</a>)</li> <li><a href="https://github.com/smartcontractkit/chain-selectors/commit/d888fe45fe5d452ec3f6e7d0e820227c44e26827"><code>d888fe4</code></a> feat: introduce remote chain fecthing api (<a href="https://redirect.github.com/smartcontractkit/chain-selectors/issues/159">#159</a>)</li> <li><a href="https://github.com/smartcontractkit/chain-selectors/commit/4fc7e0fbd1a90ba5770cf2d6ad95ae3292e5a0c9"><code>4fc7e0f</code></a> feat: generate all_selectors.yml (<a href="https://redirect.github.com/smartcontractkit/chain-selectors/issues/158">#158</a>)</li> <li>See full diff in <a href="https://github.com/smartcontractkit/chain-selectors/compare/v1.0.85...v1.0.89">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joe Huang <[email protected]>
Signed-off-by: Pablo <[email protected]>
# Conflicts: # .mockery.yaml # sdk/evm/utils.go # signable_test.go # timelock_proposal_test.go
| } | ||
|
|
||
| // FetchInspectors gets a map of inspectors for the given chain metadata and chain clients | ||
| func (b *MCMInspectorFetcher) FetchInspectors( |
Contributor
There was a problem hiding this comment.
I don't get why we need to introduce an "InspectorFetcher". Wouldn't it be more consistent to add a method that matching what we have for converters? -- say BuildInspectorsForTimelockProposal?
|
|
||
| return aptos.NewInspector(client, role), nil | ||
| case chainsel.FamilySui: | ||
| client, signer, ok := chains.Sui(rawSelector) |
Contributor
There was a problem hiding this comment.
why not chains.SuiClient. I know it returns the signer as well, but it's more consistent with the name used for the other chains
| ) | ||
|
|
||
| // TODO: this interface should come from chainlink-sui when available | ||
| type SuiSigner interface { |
Contributor
There was a problem hiding this comment.
why can't this be defined inside the sui sdk? import cycles?
| GetAddress() (string, error) | ||
| } | ||
|
|
||
| type ContractDeployBackend interface { |
Contributor
There was a problem hiding this comment.
same question here.. can't this be defined in sdk/evm?
| } | ||
|
|
||
| // GetOpCount queries the on-chain MCMS contract for the current op count of the given chain. | ||
| func (m *TimelockProposal) GetOpCount( |
Contributor
There was a problem hiding this comment.
I don't think we should define this in new method in this PR? If we're going to add convenience wrappers for the inspector functions, we should probably do so in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another approach based on smartcontractkit/chainlink-deployments-framework#667 . Now moving it to mcms lib instead of cldf + adding new interface to allow dependency injection without creating circular dependencies between the repos.