-
Notifications
You must be signed in to change notification settings - Fork 0
Add desktop wallet setup and alternative RPC #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
README.md
Outdated
| 1. Download [TON Keeper](https://tonkeeper.com/) on iOS or Android | ||
| ### Mobile (Tonkeeper App) | ||
|
|
||
| 1. Download [Tonkeeper](https://tonkeeper.com/) on iOS or Android |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make sure that these are the exact steps for the mobile app, because I wrote the specifically for the desktop wallet. Are mobile wallet instructions necessary? Everything else in the starter kit is done on a computer anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@woogieboogie-jl unless its unavoidable i would recommend using only desktop wallet setup steps. in the actual getting started steps. If you wish to inform users that there are mobile options then just link the mobile wallet in a sentence and leave at that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Now uses only desktop wallet setup steps (excluded mobile setup)
- Double-checked and made corrections to the TONkeepers desktop wallet setup steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. will let @thodges-gh close out as i've not reviewed as deep as he has.
33aef36 to
a38cdd2
Compare
zeuslawyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reflecting remaining minor feedbacks to the readme