Skip to content

Update block renderer #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update block renderer #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 38 additions & 24 deletions src/renderers/block-renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,33 +30,47 @@ export default class BlockRenderer extends React.PureComponent<RendererProps> {
// This is useful to set global styles such as fonts
const rootStyles = this.context[channel];

const isChildrenInline = React.Children.toArray(children).every(
child =>
child
? typeof child === "string" ||
INLINE_TAGS.includes(child.props.tagName)
: true
);
const childrenGroups = [];

React.Children.toArray(children).forEach(child => {
const isInline =
child &&
(typeof child === "string" ||
INLINE_TAGS.includes(child.props.tagName));
const lastGroup =
childrenGroups.length > 0
? childrenGroups[childrenGroups.length - 1]
: null;
if (lastGroup && lastGroup.isInline === isInline) {
lastGroup.children.push(child);
} else {
childrenGroups.push({
key: childrenGroups.length,
isInline,
children: [child]
});
}
});

return (
<View {...rest} style={viewStyles}>
{isChildrenInline ? (
<TextRenderer style={textStyles}>{children}</TextRenderer>
) : (
React.Children.map(children, child => {
if (typeof child === "string") {
// Since View cannot contain string, nest it in text renderer
return <TextRenderer style={textStyles}>{child}</TextRenderer>;
}

if (child) {
return React.cloneElement(child, {
style: [rootStyles, textStyles, child.props.style]
});
}

return child;
})
{childrenGroups.map(
group =>
group.isInline ? (
<TextRenderer key={group.key} style={textStyles}>
{group.children}
</TextRenderer>
) : (
React.Children.map(group.children, child => {
if (child) {
return React.cloneElement(child, {
key: group.key,
style: [rootStyles, textStyles, child.props.style]
});
}
return child;
})
)
)}
</View>
);
Expand Down