Max/esmodules

[maxwellpothier]

This is branched off the changes created by @akadoshin here: #90

[camiblanch]

Not a huge deal, but there are newer versions of this package available that we should use. The version listed here has a bunch of warnings for the glob versions used. If you update to v28 those warnings go away

[camiblanch]

Should the other example files also be renamed to .mjs? Or is just one needed to make sure rollup is working correctly?

[akadoshin]

I don't think it's necessary, as the other examples work fine with CommonJS. However, if you'd like to add new examples using .mjs, I’m not opposed to it.

[camiblanch]

the build command should be added as part of the publish command. I think

publish: test version build upload unversion should work?

In addition, we should define a .npmignore file with the following lines in order to not publish unecessary files npm (not for privacy reasons, but just for keeping things tidy)

src/
tests/
node_modules/
examples/

.env
.vscode/
.idea/
.DS_Store
.eslintignore
.eslintrc.json
.git/
.github/
.gitignore
.prettierignore
.prettierrc

*.log

You can test out what will be published to npm with npm publish --dry-run

[akadoshin]

@camiblanch @maxwellpothier I agree with reducing the package size. When I first looked at the project, I wasn't sure why all the code was being exported in the package, so I left it as it was. However, in this case, it would be better to specify which files to include rather than excluding them. In the package.json, you can do something like this:

{
  "files": [
    "dist",
    "README.md",
    "LICENSE"
  ]
}

This way, you’re only including the necessary build folder (dist), which is meant for publishing the package to npm, and other relevant files like the README and license.

[maxwellpothier]

@camiblanch @akadoshin

I've made those changes to update our dependencies and publishing process.

I originally upgraded chai to v5, but they released breaking changes that no longer support commonjs. I've made a task in our backlog to get this handled, because this change is out of the scope of this PR. The chai version is still the same here.

[camiblanch]

Looks great!