Improve file reading and Particle creation#393
Open
Hendrik1704 wants to merge 9 commits intosparkx_develfrom
Open
Improve file reading and Particle creation#393Hendrik1704 wants to merge 9 commits intosparkx_develfrom
Hendrik1704 wants to merge 9 commits intosparkx_develfrom
Conversation
Collaborator
Author
|
After a bit of playing around I found that the electron was causing some problems because it is so light. This is a problem in the function where Jetscape input is used when the mass is computed from the energy and momentum. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors how SPARKX loads files in a single run (~5% performance improvement) and it implements caching and fast index lookup in the Particle class. That seemed to be a major bottleneck that is fixed now. Especially important for large events passed as an array initialization of Particle, this can lead to a speedup of ~40-50%.
The one pass read of files closes #355.