Introduce subcommand to 'set' an absolute volume#38
Open
LSLeary wants to merge 2 commits intosmasher164:mainfrom
Open
Introduce subcommand to 'set' an absolute volume#38LSLeary wants to merge 2 commits intosmasher164:mainfrom
LSLeary wants to merge 2 commits intosmasher164:mainfrom
Conversation
Incrementing raw volume amplitudes results in oversensitivity at low volumes and undersensitivity at high volumes. To straighten the response curve as perceived by human ears, we express user-facing volumes in the cube-root domain. This produces percentage values in line with e.g. pwvucontrol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orthogonal to #37 in principle, but nonetheless based upon it since the changes aren't quite independent.
Tested on my system with
cargo run; appears to work as intended.Disclaimer: I don't know Rust, nor am I fluent in any other C-like language—I'm making it up as I go along. These changes require attention from someone who actually knows what they're doing.