excessive logging overhead #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sirivio, thank you for contributing. Can you please describe how the end-user would change the default log level, and have you tested it to make sure it works? Thanks. |
|
pr is not working as intended, sorry! Idea was that end user is able to change logging according node-red https://nodered.org/docs/writing-functions pages "Logging events" section and it's configuration which is described in https://nodered.org/docs/configuration "Runtime Configuration"/logging. |
|
|
|
Thanks for the update. So are you still working on it, then? Can you please remove any commented lines of code for your final version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check this, for ETL type node-red batch jobs the logging is too excessive. In bluemix enviroment, it basically crashes the service dashboard page.