Relocation for analyzed flags & paper modifications#18
Merged
Conversation
Added functionality to set the `analyzed` and `adjoint_analyzed` flags within the `analyze` and `analyze_adjoint` methods directly. Now, users do not have to set these flags within their private/protected methods (although they still can without causing issues).
Reflects the change made to Analysis base class, which now sets the flags for `analyzed` and `adjoint_analyzed` directly within the base class during execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the location where the
analyzedandadjoint_analyzedboolean flags are set for the Analysis base class to eliminate the need for a user to include them when creating subclasses. Also, various modifications for the JOSS paper prior to submission.