Skip to content

Mphys coord initialization #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Asthelen wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Mphys coord initialization #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b61818e
optional initial coordinates for mphys builder to initialize meld with
Asthelen Mar 25, 2025
49b1a6a
minor mods based on Kevin's original demo
Asthelen Mar 25, 2025
eaddc79
forgot to change initial to ref in two places
Asthelen Mar 25, 2025
1a10318
fix for meld lfd builder
Asthelen Apr 4, 2025
b3e63c6
Merge branch 'smdogroup:master' into mphys_coord_initialization
Asthelen Jun 10, 2025
59ce661
run black
Asthelen Jun 10, 2025
cac83e7
missing mphysvariables in mphys_meld_lfd
Asthelen Jun 10, 2025
c0783d2
Merge branch 'smdogroup:master' into mphys_coord_initialization
Asthelen Aug 12, 2025
b20bed9
rename use_ref_coordinates to use_reference_coordinates; tweaks to lf…
Asthelen Aug 12, 2025
9a3f99a
lint format
Asthelen Aug 12, 2025
3ee3b2a
Merge branch 'smdogroup:master' into mphys_coord_initialization
Asthelen Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 47 additions & 1 deletion funtofem/mphys/mphys_meld.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ def initialize(self):
self.options.declare("aero_nnodes")
self.options.declare("check_partials")
self.options.declare("bodies", recordable=False)
self.options.declare(
"use_reference_coordinates",
types=bool,
desc="Use separate aero and struct reference coordinates for transfer scheme initialization (same variable name with '_ref' appended)",
)

self.struct_ndof = None
self.struct_nnodes = None
Expand Down Expand Up @@ -63,6 +68,21 @@ def setup(self):
desc="structural node displacements",
tags=["mphys_coupling"],
)
if self.options["use_reference_coordinates"]:
self.add_input(
X_STRUCT0 + "_ref",
shape_by_conn=True,
distributed=True,
desc="baseline structural node coordinates with which to initialize MELD",
tags=["mphys_coordinates"],
)
self.add_input(
X_AERO0 + "_ref",
shape_by_conn=True,
distributed=True,
desc="baseline aero surface node coordinates with which to initialize MELD",
tags=["mphys_coordinates"],
)

# outputs
self.add_output(
Expand All @@ -77,8 +97,31 @@ def setup(self):
# partials
# self.declare_partials(U_AERO,[X_STRUCT0,X_AERO0,U_STRUCT])

def _initialize_xfer(self, inputs, body):
if self.options["use_reference_coordinates"]:
x_s0 = np.array(
inputs[X_STRUCT0 + "_ref"][body.struct_coord_indices],
dtype=TransferScheme.dtype,
)
x_a0 = np.array(
inputs[X_AERO0 + "_ref"][body.aero_coord_indices],
dtype=TransferScheme.dtype,
)
else:
x_s0 = np.array(
inputs[X_STRUCT0][body.struct_coord_indices],
dtype=TransferScheme.dtype,
)
x_a0 = np.array(
inputs[X_AERO0][body.aero_coord_indices], dtype=TransferScheme.dtype
)
body.meld.setStructNodes(x_s0)
body.meld.setAeroNodes(x_a0)
body.meld.initialize()

def compute(self, inputs, outputs):
for body in self.bodies:

x_s0 = np.array(
inputs[X_STRUCT0][body.struct_coord_indices],
dtype=TransferScheme.dtype,
Expand All @@ -100,7 +143,7 @@ def compute(self, inputs, outputs):
body.meld.setAeroNodes(x_a0)

if not body.initialized_meld:
body.meld.initialize()
self._initialize_xfer(inputs, body)
body.initialized_meld = True

body.meld.transferDisps(u_s, u_a)
Expand Down Expand Up @@ -556,6 +599,7 @@ def __init__(
check_partials=False,
linearized=False,
body_tags=None,
use_reference_coordinates=False,
):
self.aero_builder = aero_builder
self.struct_builder = struct_builder
Expand All @@ -565,6 +609,7 @@ def __init__(
self.under_check_partials = check_partials
self.linearized = linearized
self.body_tags = body_tags if body_tags is not None else []
self.use_reference_coordinates = use_reference_coordinates

if len(self.body_tags) > 0: # make into lists, potentially for different bodies
if not hasattr(self.n, "__len__"):
Expand Down Expand Up @@ -641,6 +686,7 @@ def get_coupling_group_subsystem(self, scenario_name=None):
aero_nnodes=self.nnodes_aero,
check_partials=self.under_check_partials,
bodies=self.bodies,
use_reference_coordinates=self.use_reference_coordinates,
)

load_xfer = MeldLoadXfer(
Expand Down
81 changes: 65 additions & 16 deletions funtofem/mphys/mphys_meld_lfd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,16 @@

import numpy as np
import openmdao.api as om
from .mphys_meld import MeldBuilder
from mphys import MPhysVariables

from funtofem import TransferScheme

from .mphys_meld import MeldBuilder

# Set MPhys variable names
X_STRUCT0 = MPhysVariables.Structures.COORDINATES
X_AERO0 = MPhysVariables.Aerodynamics.Surface.COORDINATES_INITIAL


class ModeTransfer(om.ExplicitComponent):
def initialize(self):
Expand All @@ -16,14 +22,19 @@ def initialize(self):
self.options.declare("ndof_struct")
self.options.declare("nnodes_aero")
self.options.declare("meld")
self.options.declare(
"use_reference_coordinates",
types=bool,
desc="Use separate aero and struct reference coordinates for transfer scheme initialization (same variable name with '_ref' appended)",
)

self.first_pass = True

def setup(self):
# self.set_check_partial_options(wrt='*',method='cs',directional=True)

self.add_input(
"x_struct0",
X_STRUCT0,
shape_by_conn=True,
distributed=True,
tags=["mphys_coordinates"],
Expand All @@ -35,8 +46,23 @@ def setup(self):
tags="mphys_coupling",
)
self.add_input(
"x_aero0", shape_by_conn=True, distributed=True, tags=["mphys_coordinates"]
X_AERO0, shape_by_conn=True, distributed=True, tags=["mphys_coordinates"]
)
if self.options["use_reference_coordinates"]:
self.add_input(
X_STRUCT0 + "_ref",
shape_by_conn=True,
distributed=True,
desc="baseline structural node coordinates with which to initialize MELD",
tags=["mphys_coordinates"],
)
self.add_input(
X_AERO0 + "_ref",
shape_by_conn=True,
distributed=True,
desc="baseline aero surface node coordinates with which to initialize MELD",
tags=["mphys_coordinates"],
)

nmodes = self.options["nmodes"]
self.nnodes_aero = self.options["nnodes_aero"]
Expand All @@ -51,11 +77,22 @@ def setup(self):
tags=["mphys_coupling"],
)

def _initialize_xfer(self, inputs, meld):
if self.options["use_reference_coordinates"]:
aero_X = np.array(inputs[X_AERO0 + "_ref"], dtype=TransferScheme.dtype)
struct_X = np.array(inputs[X_STRUCT0 + "_ref"], dtype=TransferScheme.dtype)
else:
aero_X = np.array(inputs[X_AERO0], dtype=TransferScheme.dtype)
struct_X = np.array(inputs[X_STRUCT0], dtype=TransferScheme.dtype)
meld.setStructNodes(struct_X)
meld.setAeroNodes(aero_X)
meld.initialize()

def compute(self, inputs, outputs):
meld = self.options["meld"]
nmodes = self.options["nmodes"]
aero_X = np.array(inputs["x_aero0"], dtype=TransferScheme.dtype)
struct_X = np.array(inputs["x_struct0"], dtype=TransferScheme.dtype)
aero_X = np.array(inputs[X_AERO0], dtype=TransferScheme.dtype)
struct_X = np.array(inputs[X_STRUCT0], dtype=TransferScheme.dtype)

aero_modes = np.zeros((aero_X.size, nmodes), dtype=TransferScheme.dtype)
struct_modes = inputs["mode_shapes_struct"].reshape((-1, nmodes))
Expand All @@ -64,7 +101,7 @@ def compute(self, inputs, outputs):
meld.setStructNodes(struct_X)

if self.first_pass:
meld.initialize()
self._initialize_xfer(inputs, meld)
self.first_pass = False

struct_mode = np.zeros(self.nnodes_struct * 3, dtype=TransferScheme.dtype)
Expand All @@ -81,8 +118,8 @@ def compute(self, inputs, outputs):
def compute_jacvec_product(self, inputs, d_inputs, d_outputs, mode):
meld = self.options["meld"]
nmodes = self.options["nmodes"]
x_s0 = np.array(inputs["x_struct0"], dtype=TransferScheme.dtype)
x_a0 = np.array(inputs["x_aero0"], dtype=TransferScheme.dtype)
x_s0 = np.array(inputs[X_STRUCT0], dtype=TransferScheme.dtype)
x_a0 = np.array(inputs[X_AERO0], dtype=TransferScheme.dtype)

meld.setStructNodes(x_s0)
meld.setAeroNodes(x_a0)
Expand Down Expand Up @@ -128,19 +165,19 @@ def compute_jacvec_product(self, inputs, d_inputs, d_outputs, mode):
] -= np.array(prod[i::3], dtype=np.float64)

# du_a/dx_a0^T * psi = - psi^T * dD/dx_a0 in F2F terminology
if "x_aero0" in d_inputs:
if X_AERO0 in d_inputs:
prod = np.zeros(
d_inputs["x_aero0"].size, dtype=TransferScheme.dtype
d_inputs[X_AERO0].size, dtype=TransferScheme.dtype
)
meld.applydDdxA0(du_a, prod)
d_inputs["x_aero0"] -= np.array(prod, dtype=float)
d_inputs[X_AERO0] -= np.array(prod, dtype=float)

if "x_struct0" in d_inputs:
if X_STRUCT0 in d_inputs:
prod = np.zeros(
self.nnodes_struct * 3, dtype=TransferScheme.dtype
)
meld.applydDdxS0(du_a, prod)
d_inputs["x_struct0"] -= np.array(prod, dtype=float)
d_inputs[X_STRUCT0] -= np.array(prod, dtype=float)


class MeldLfdBuilder(MeldBuilder):
Expand All @@ -153,15 +190,27 @@ def __init__(
n=200,
beta=0.5,
check_partials=False,
use_reference_coordinates=False,
):
self.nmodes = nmodes
super().__init__(aero_builder, struct_builder, isym, n, beta, check_partials)
super().__init__(
aero_builder,
struct_builder,
isym,
n,
beta,
check_partials,
False,
None,
use_reference_coordinates,
)

def get_post_coupling_subsystem(self):
def get_post_coupling_subsystem(self, scenario_name=None):
return ModeTransfer(
nmodes=self.nmodes,
nnodes_struct=self.nnodes_struct,
ndof_struct=self.ndof_struct,
nnodes_aero=self.nnodes_aero,
meld=self.meld,
meld=self.bodies[0].meld, # TODO: implement multi-body mode transfer
use_reference_coordinates=self.use_reference_coordinates,
)
Loading